moreThanFAANGM icon indicating copy to clipboard operation
moreThanFAANGM copied to clipboard

Published 20 hours ago • verified publisher icon Kaustubh-Natuskar

Added a new company "Planful", decent company with good package and reviews on glassdoor.

Open mehul1011 opened this issue 2 years ago • 5 comments

Congratulations on making a pull request!

Please make sure you check all the items.

  • [x] The numbering of the company that you added starts with 1.
  • [x] You have increased the Total Companies Added count.

mehul1011 avatar Sep 10 '22 10:09 mehul1011

Thanks man Why is it having 404 additions 🙂, I'm not able to open that much on mobile.

Kaustubh-Natuskar avatar Sep 10 '22 10:09 Kaustubh-Natuskar

So basically it's just some indentation thing that happened because i used a prettier extension on VScode. You can check it later when you are on the desktop, nothing is leading to any bug or anything i am sure.

mehul1011 avatar Sep 11 '22 06:09 mehul1011

Great But it has deleted the spaces after a company section it will fine locally but on web and markdown it'll not generate new line so everything will be on same line. Please add two spaces after each section for example

  1. Benchmark This helps putting us a new line below. Don't use any extensions

Thank you for contributing :)

Kaustubh-Natuskar avatar Sep 11 '22 06:09 Kaustubh-Natuskar

Oh okay, makes sense But instead of 2 spaces, can we use something else to work around? Like '\n' or something, because later someone will come up with this problem again.

mehul1011 avatar Sep 12 '22 04:09 mehul1011

Can you check out my forked repo (https://github.com/mehul1011/moreThanFAANGM?organization=mehul1011&organization=mehul1011)

Things seem to be fine.

mehul1011 avatar Sep 12 '22 04:09 mehul1011