KaufmannDigital.GDPR.CookieConsent icon indicating copy to clipboard operation
KaufmannDigital.GDPR.CookieConsent copied to clipboard

Language additions and fixes

Open hphoeksma opened this issue 11 months ago • 4 comments

Adds a missing language label, adds a few languages and cleans up some of the xlf files.

I would suggest to remove the xml:space="preserve" attributes throughout all languages files. Happy to do this.

Fixes: #57

hphoeksma avatar Mar 22 '24 13:03 hphoeksma

@hphoeksma Thanks for your PR, looking good so far. As mentioned in the comment above, I'll do some checks and then release a new Version, together with other upcoming changes. Should be done by tomorrow.

Can you explain me the benefit of removing the xml:space="preserve" from xlf files? To be hornest, I've got no idea why it is there. Probably we just copied the XLF-structure from original Neos xlf files and kept it that way.

Nikdro avatar Apr 11 '24 16:04 Nikdro

@Nikdro I started out the same, copying the original Neos files and change those. However I have found the formatting the XLF files is a pain when using xml:space="preserve". What I understand is that this is used for values where line breaks, tabs, spaces etc are important. I usually only use this parameter when I see it is needed (which is never since where whitespace is relevant I am always in need of the <CDATA[ ... ]]> encapsulating... I also noticed weblate (which I use mostly when dealing with lots of files) doesn't add this attribute.

hphoeksma avatar Apr 12 '24 07:04 hphoeksma

Thanks for your Feedback @hphoeksma!

Would you do that changes and add it to this PR/branch? Then I'll do my tests also with that one included and it could go into the new version. Thanks!

Nikdro avatar Apr 12 '24 09:04 Nikdro

Sure, I hope to be able to do this today!. Done!

hphoeksma avatar Apr 12 '24 09:04 hphoeksma

Thanks again! This is now included in 5.4.0

Nikdro avatar Apr 22 '24 07:04 Nikdro