KatyTaylor

Results 61 comments of KatyTaylor

Some investigation: There's a validation method in `batch.rb` as follows: ``` def batch_meets_minimum_size if min_size && (requests.size < min_size) errors.add :base, "You must create batches of at least #{min_size} requests...

Previous relevant PR (changes for NovaseqX) - https://github.com/sanger/sequencescape/pull/3794 and where flowcell_types was added - https://github.com/sanger/sequencescape/pull/3649

The 'Flowcell type' referenced by the story is recorded in the `request_metadata` table as `requested_flowcell_type`. It is displayed in the 'Flowcell requested' column in the sequencing inbox table (https://training.sequencescape.psd.sanger.ac.uk/pipelines/52), e.g.:...

I think the requirement "Restrict mixing of requests (sample pool) for different types of flowcells (10B, 25B, 1.5B) on the same batch." is already met by the below code, although...

@SujitDey2022 could we have some acceptance criteria? Would it be something like: When selecting requests from the NovaSeq X pipeline inbox (Pipelines tab > NovaSeqX PE): - If I select...

I've sized this as small as I think it's just adding some more server-side validation in the `batch.rb` class.

It's difficult to be 100% certain about this, because the study data has been changed since the errors were experienced, but here's my best guess. **TL;DR** The study was not...

Communication sent to Liz C (requestor): > I’m working on an issue that it looks like you raised - [DPL-1105 [BUG] A study set to never release should not require...

Reply: > Thanks for following up on this – that makes sense because I actually generated a “request additional sequencing” request on a never release study at the end of...

Was agreed this was not urgent and could be done in 'Phase 3'.