katello icon indicating copy to clipboard operation
katello copied to clipboard

Fixes #35120 - Indexing with additive content

Open sjha4 opened this issue 2 years ago • 1 comments

What are the changes introduced in this pull request?

We should not enforce "additive" indexing. Sync_policy (mirroring_policy on the UI) should be enforced at the time of sync and passed to pulp.(Happens currently). Once pulp syncs according to the provided policy, katello should trust pulp as source of truth and not force additive content beyond what pulp does.

Considerations taken when implementing this change?

What are the testing steps for this pull request?

  1. Create a yum repo with URL : https://fixtures.pulpproject.org/rpm-unsigned/
  2. Set Mirroring Policy to "Additive" and Retain package versions to 5
  3. Sync repo.
  4. You should have 35 rpms.
  5. Edit repo and set Retain package versions to 1.
  6. Complete sync the repo

Without change: Pulp will have a new version of repo with 31 rpms. Katello still shows 35 rpms. With change: Pulp and katello rpms count will match.

sjha4 avatar Aug 09 '22 18:08 sjha4

Issues: #35120

theforeman-bot avatar Aug 09 '22 18:08 theforeman-bot

Code looks fine, starting to test

chris1984 avatar Aug 15 '22 19:08 chris1984