HeaderRecyclerView icon indicating copy to clipboard operation
HeaderRecyclerView copied to clipboard

Bind methods should use the generic type declared in the class to avoid downcasting

Open pedrovgs opened this issue 9 years ago • 4 comments

With the current implementation you have to downcast the view holder to be albe to use it inside bind methods. We should parametrize the class with generics to avoid that downcast.

pedrovgs avatar May 25 '15 18:05 pedrovgs

But even the item view can have different types, and they may use different ViewHolder, so is this really necessary?

cmicat avatar Feb 02 '16 15:02 cmicat

The usage of generics is going to be always safer.

pedrovgs avatar Feb 02 '16 15:02 pedrovgs

The problem is that if you fix this, you have to pass in generic type infomation in the class, and this will break existing usage.

cmicat avatar Feb 02 '16 16:02 cmicat

We will publish the new release as a major if needed.

pedrovgs avatar Feb 02 '16 16:02 pedrovgs