PoracleJS icon indicating copy to clipboard operation
PoracleJS copied to clipboard

refactor: swap to uicons.js lib

Open TurtIeSocks opened this issue 1 year ago • 3 comments

Description

Simplify the poracle uicons class by moving large portions of the logic to the external uicons.js lib, written by yours truly and implemented in ReactMap and other pogo tools.

Motivation and Context

This keeps our approach to uicons in sync.

How Has This Been Tested?

~~Currently untested.~~ Deployed to prod and working as expected.

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.

TurtIeSocks avatar Aug 18 '24 19:08 TurtIeSocks

At a cost of deprecating support for telegram non uicons repos?

jfberry avatar Aug 18 '24 19:08 jfberry

I don't believe this PR deprecates any functionality.

TurtIeSocks avatar Aug 18 '24 19:08 TurtIeSocks

As discussed in Discord, this has been verified to be working with Discord and Telegram and is ready to merge.

TurtIeSocks avatar Sep 02 '24 12:09 TurtIeSocks