react-drag-drop-files icon indicating copy to clipboard operation
react-drag-drop-files copied to clipboard

Published 20 hours ago • verified publisher icon KarimMokhtar

feat: added husky and lint-staged

Open Brandontam29 opened this issue 2 years ago • 6 comments

Summary

Added husky and lint-staged. I am new to open source and doing this kind of config. I want to know if this is what you were looking for. I will probably have to do some changes before merging because I am not sure if this is good.

Key Changes

Only modified the package.json. Ran npm run test but Cannot find module 'react' from 'tests/DrawTypes.test.tsx'.

Brandontam29 avatar Jul 26 '22 23:07 Brandontam29

Hi @Brandontam29 , Thanks for your contribution, Actually we are not using tests right now as it needs a special configuration so there is no need for that command. Also could you please try to take a branch of yours and check if the linting is working? Second thing please make sure you are following the semantic PR rules so your code passes the pipeline. Thanks again for your effort.

KarimMokhtar avatar Jul 27 '22 21:07 KarimMokhtar

I don't know if you received the notification, but I just pushed the branch with commit message changed. Thank you.

Brandontam29 avatar Jul 28 '22 20:07 Brandontam29

I changed the title of the pr, sorry for the inconvenience. I hope it works this time.

Brandontam29 avatar Jul 29 '22 04:07 Brandontam29

Hi @Brandontam29 , Have you tried it locally? I have tried to test if it's gonna lint the staged files or not but it seems that it's not working. Could you please check?

KarimMokhtar avatar Aug 02 '22 23:08 KarimMokhtar

Let me test it this weekend. I have a few things going on right now.

Brandontam29 avatar Aug 03 '22 22:08 Brandontam29

@Brandontam29 have you reached a new update on this or should i close the PR?

KarimMokhtar avatar Nov 23 '22 22:11 KarimMokhtar