react-drag-drop-files icon indicating copy to clipboard operation
react-drag-drop-files copied to clipboard

Published 20 hours ago • verified publisher icon KarimMokhtar

Add optional property labelAfter to set label after drop operation

Open JorgenLindell opened this issue 3 years ago • 4 comments

Summary

Introducing a label to be shown after the drop is completed. Current solution always says "File is uploaded", but in my use case the file should not be uploaded on drop, but rather at a click on a separate button. Then the default text is confusing for the user, as it seems that the upload is already done at that point.

Key Changes

  • add (optional) property labelAfter which is used instead of the default one in case it is defined.

Check List

  • [x] The changes to the "Readme" file(if needed)
  • [x] The changes not breaking any old rule of the library or usage

JorgenLindell avatar Feb 21 '22 19:02 JorgenLindell

@KarimMokhtar can we merge this PR?

Victor-Varghese avatar Mar 29 '22 15:03 Victor-Varghese

@KarimMokhtar can we merge this PR?

Unfortunately, there are required changes that have not been made yet. If you could make them done it's gonna be great.

KarimMokhtar avatar Mar 29 '22 15:03 KarimMokhtar

pretty please! the "upload another?" text is not matching when the actual submit only happens later and the user has to full out other form fields

bumi avatar Aug 22 '22 22:08 bumi

@KarimMokhtar what are the requirements needed to finish and merge this PR?

danilloestrela avatar Dec 19 '22 22:12 danilloestrela