Karel-Jan Van Haute

Results 23 issues of Karel-Jan Van Haute

When the necessary cookies are not set, we should block the video and show a message that the user needs to change the settings in order to see the video...

🌱 twig

Suggested format: Name Site - Extra optional meta title content Default format other pages: title page - name website

📦 plugins

Check if all plugin examples are still working and up to date. Add some extra comments if needed?

📜 typescript
🌱 twig

There is something called the HTMLDialogElement (https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement). This is a native implementation of a dialog. It should be well-supported by now by all browsers. The trickiest is safari 15.4 which...

📜 typescript

Our toggle (accordion) component is now made with aria in mind and works ok. But there is a native construction for things like this. This should be better to use....

📜 typescript

Change the dynamicContentObserver to this. ```js DOMHelper.onDynamicContent( document.documentElement, "select[data-s-autocomplete]", (autocompletes) => { Array.from(autocompletes).forEach((ac: HTMLSelectElement, index) => { if (!ac.hasAttribute("data-s-autocomplete")) return; new Autocomplete(ac, index); }); }, "data-s-autocomplete" ); ```

📜 typescript

Check out how Jira is doing it. Nice solution.

See KULVAI-438. Add the popstate listener to the initReloadedClicks function. ```ts private initReloadedClicks() { document.addEventListener( 'click', (e) => { // loop parent nodes from the target to the delegation node...

Fixes #350 ### Description This adds the option to give the dialog a specific class. This gives the option to style the dialog with specific styles.