Kavita icon indicating copy to clipboard operation
Kavita copied to clipboard

Series cover is selected from specials

Open Sulframus opened this issue 2 years ago • 2 comments

If this is a feature request, request here instead. Feature requests will be deleted from Github.

Please put as much information as possible to help me understand your issue. OS, browser, version are very important!

Describe the bug The cover for the series gets selected from Specials instead of Books

To Reproduce Steps to reproduce the behavior:

  1. Have a book library
  2. Have series with both a standard volume and a special
  3. When series get scanned, cover will be used from specials

Expected behavior Cover will be selected from standard volume

Screenshots image image

Desktop (please complete the following information):

  • OS: Docker
  • Browser: Brave
  • Version: 0.5.5.15

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

Sulframus avatar Aug 26 '22 19:08 Sulframus

This is actually how Book libraries work by default as usually Books are treated as special. I need to think about how to handle an enhancement like this.

majora2007 avatar Aug 28 '22 16:08 majora2007

Would it be possible to offer all covers in this series and you just choose the one you like? That way there doesn't have to be any special code for determining which cover to use and the covers of the individual volumes are in the DB anyway. When you go to the cover setting where you can upload a file, there would be the volume covers and you just select one like you can after uploading.

Salindris avatar Aug 30 '22 10:08 Salindris

Interesting enough, for me, the summary is from volume 1 (index 1) and it seems the tags (and cover) are from series index 0.

image

ocgineer avatar Sep 23 '22 02:09 ocgineer

I thought I've already implemented this cover selection code so you can switch it to any in the series, while keeping the original cover logic, but it looks like I only had extended that to volume and collections, so I'll ensure series cover selection gets the same treatment.

majora2007 avatar Sep 23 '22 11:09 majora2007