open-cravat icon indicating copy to clipboard operation
open-cravat copied to clipboard

Oncokb deletion

Open jkobject opened this issue 2 years ago • 5 comments

Hi!

Thank you for the great tool! I am wondering why you have recently removed oncoKB. (This is a really useful annotator for us at DepMap)

Best,

jkobject avatar Apr 08 '22 14:04 jkobject

@jkobject Sorry, it must have been a mistake. It has been restored.

rkimoakbioinformatics avatar Apr 09 '22 00:04 rkimoakbioinformatics

Hi!

I might not really understand how this repo work because oncoKB I don't see reverts on the master branch so oncokb seems to still be absent from this repo.

I tried to run the oncokb annotator a couple days ago and it seems to have returned null for every mutations (which seems unlikely).

jkobject avatar Apr 12 '22 12:04 jkobject

Rick,

There may be a special case here but in general, I don’t think users who request support for OC should be pointed to your repo for fixes. I know you have been carrying the support load and that it looked like there would be no future support for OC but with the grant coming back on-line in the next few weeks, we should talk this over.

Mike

From: Rick Kim @.> Sent: Tuesday, April 12, 2022 9:50 AM To: KarchinLab/open-cravat-modules-karchinlab @.> Cc: Subscribed @.***> Subject: Re: [KarchinLab/open-cravat-modules-karchinlab] Oncokb deletion (Issue KarchinLab/open-cravat#220)

@jkobject https://github.com/jkobject I have reverted it but the deletion must have come back to the repo by another push.

I keep the updates I make on the oncokb module at https://github.com/rkimoakbioinformatics/oak-cravat-modules/tree/master/annotators/oncokb. Please see the readme there for how to use this module. Without token.txt file with an access API, the module's result will be empty. What you get with oc module install oncokb is the latest version in this repo.

— Reply to this email directly, view it on GitHub https://github.com/KarchinLab/open-cravat/issues/220 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADC6Q67WHCEIOQHJ5SMIEKTVEV5PNANCNFSM5S42B3FA . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/ADC6Q6YF6GWEZCX3HWUXZ6LVEV5PNA5CNFSM5S42B3FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIFPSRTQ.gif Message ID: @.*** @.***> >

mryaninsilico avatar Apr 12 '22 14:04 mryaninsilico

Thanks for the help,

Should I ask my next question on the open Cravat's main repo?

I have ran the annotation with oncokb, listed the keyfile in the right folder, oncokb annotator ran for a long time and the output vcf was annotated but I see every mutations in the file having the exact same annotation: OC_oncokb__oncogenic=Unknown;OC_oncokb__knownEffect=Unknown

Moreover, it seems that oncokb is very slow (takes 2 days to annotate one WGS file)... We have thousands that we would want to annotate.

My guess is that it can only happen if you are making requests to the API for every mutations?

Would there be a way to make this process much faster?

  1. keeping a record of oncoKB's annotations? or
  2. only running it on coding regions? (it seems oncoKB only has annotation for these)

What do you think?

jkobject avatar May 26 '22 13:05 jkobject

Hi,
Did you find a solution for using OncoKB module with OpenCravat? I have the same issue, it's running extremely slow.

Thanks

drstormR avatar Sep 25 '23 09:09 drstormR