kaoto-ui icon indicating copy to clipboard operation
kaoto-ui copied to clipboard

Deleting the source code thows an exception

Open lordrip opened this issue 1 year ago • 4 comments

Describe the Bug

An unhandled exception is thrown upon deleting the source code

Steps to Reproduce the Bug or Issue

  1. Starting with a blank canvas.
  2. Delete all the source code.
  3. See the exception thrown.

Screenshots or Videos

Screencast from 2023-06-13 16-09-37.webm

Platform

  • OS: [Linux]
  • Browser: [Firefox]
  • Version: [1.0.0]

lordrip avatar Jun 13 '23 14:06 lordrip

Investigating this issue let me to figuring, that the error was there for quite a long time, but was visible only in the console. Only after this commit - upgrading the webpack-dev-server, which introduced this fix - overlay displays unhandled promise rejection started the error appear in the overlay.

That being said, there seems to be an issue with the version of monaco-editor in the package.json. The issue seems to be occurring since the upgrade to version 0.35.0 - prior to this version there was no such error.

The question now is, whether we want to downgrade the monaco-editor to version 0.34.1, or should I try to find another solution.

tplevko avatar Jun 29 '23 13:06 tplevko

I think that it will be better to leave the version downgrade as a last-resort solution since in production mode, there's a console error only.

lordrip avatar Jun 29 '23 14:06 lordrip

Just for testing purposes, I downgraded monaco-editor to 0.34.1 and I don't see the error message in Firefox :thinking:

lordrip avatar Jun 30 '23 09:06 lordrip

I know - going through the changelog from monaco-editor 0.35.0, I can't figure out, what might have introduced this error.

tplevko avatar Jun 30 '23 11:06 tplevko