kano-toolset icon indicating copy to clipboard operation
kano-toolset copied to clipboard

Fix for Quality/Signal level output variations

Open darryllee opened this issue 10 years ago • 2 comments

As mentioned in https://github.com/KanoComputing/kano-toolset/issues/198, the format of Quality and Signal level changes when iwlist cannot get a range for some Access Points (or perhaps it's related to the wireless driver). At any rate, I've observed a 2Wire/AT&T U-verse router showing:

Quality:40 Signal level:0 Noise level:0

The original parser only accounts for Quality/Signal level in this format:

Quality=72/100 Signal level=65/100

This change accommodates the possibility of for a colon in addition to an equals sign, and also can handle an integer value for Quality as opposed to a fraction.

darryllee avatar Feb 26 '16 04:02 darryllee

Other than the small comment above - it looks good. After the above is fixed, I will test it.

tombettany avatar Feb 26 '16 10:02 tombettany

So uh, hey, my son wanted to mess around with Kano after some time away, and I didn't know where the right card was, so I downloaded the latest Beta, 3.15.0. Unfortunately we ran into the same bug that I filed 2 years ago. And my changes fixed the problem (again). Can somebody please merge this? I'd be surprised that this hasn't stopped others from being able to get on wireless. :-{

darryllee avatar Jul 13 '18 09:07 darryllee