amazon-clone icon indicating copy to clipboard operation
amazon-clone copied to clipboard

making a layout component for headers and footer

Open ghost opened this issue 1 year ago • 6 comments

Describe the bug

hi! @Kanika637 😁 we could make the App.js more clean to see

Expected behaviour

Layout =({children})=>{
     <Header/>
         {children}
     <Footer/>
}
main=()=>{
  return <Layout >
  Cart component 
   </Layout>
}
main=()=>{
  return <Layout >
  Product component 
   </Layout>
}

Screenshots

No response

Additional context

No response

ghost avatar Mar 14 '23 14:03 ghost

I can work on it if the issue is still active.

mud1tx avatar Mar 30 '23 08:03 mud1tx

I am trying to install the npm package but it is not running and showing some errors. Screenshot (355)

I think that some packages are deprecated.

mud1tx avatar Apr 07 '23 06:04 mud1tx

I can fix the issue without running the project, just have to add Layout component?

mud1tx avatar Apr 07 '23 06:04 mud1tx

I am trying to install the npm package but it is not running and showing some errors. Screenshot (355)

I think that some packages are deprecated.

Hey, try the command with -- force or --legacy-peer-deps as suggested. I think that would work.

Kanika637 avatar Apr 11 '23 10:04 Kanika637

Hi Can I work in this issue?

ThienBNguyen avatar May 06 '23 18:05 ThienBNguyen

@Kanika637 i open PR to fix this issue can you please review my PR i want to work on this project. Thank you

mominrazashahid avatar Aug 17 '24 19:08 mominrazashahid