Results 196 comments of Kang Lin

Please see ci 在 2024-01-20 00:30:46,"Michael Jones" ***@***.***> 写道: @jonesmz commented on this pull request. In .github/workflows/tests.yml: > @@ -30,7 +30,8 @@ jobs: libpq-dev libsqlite3-dev \ libhiredis-dev \ libmongoc-dev \...

I'm hoping to drop the makefile from the next major release.maintenance is too painful. 在 2024-01-20 00:32:11,"Michael Jones" ***@***.***> 写道: @jonesmz commented on this pull request. In Makefile.in: > MAKE_DEPS...

Forget why. It could be to keep the latest version. 在 2024-01-20 00:33:05,"Michael Jones" ***@***.***> 写道: @jonesmz commented on this pull request. In .github/workflows/msvc.yml: > @@ -39,7 +39,7 @@ jobs:...

Machine translated. Is the grammar wrong? original: 此项目包括两种日志实现: - 用成熟的日志库[log4cplus](https://github.com/log4cplus/log4cplus) - 本库原有的日志实现 [陈旧的] 在 2024-01-20 00:34:01,"Michael Jones" ***@***.***> 写道: @jonesmz commented on this pull request. In docs/Log.md: > @@ -0,0...

> You have changes in a single commit that aren't related to each other I was asking about it because it would be nice to have the commits broken up...

a label + goto It's a bad habit! At 2024-01-20 05:20:52, "Michael Jones" ***@***.***> wrote: @jonesmz commented on this pull request. In src/apps/relay/ns_ioalib_engine_impl.c: > if (!s) { ioa_network_buffer_delete(NULL, nbh); return...

@SamuelMarks @eakraly @rolandwu777 @Neustradamus @ggarber @pando-emil @irinelnistor Please review.

> Example.c - should probably be different name It is only example. After merge. if not need it, it will be deleted. The PR is only create windows service example....

@Neustradamus It is provide service interfaces. Do not modify the turnserver program. Functionality and testing has been completed. please merge! Because the turnserver program uses exit(). So it will cause...

We still use VC 2012 extensively. 在 2024-01-20 05:54:59,"Michael Jones" ***@***.***> 写道: @jonesmz commented on this pull request. In CMakeLists.txt: > @@ -6,6 +6,8 @@ project(coturn) set(CMAKE_INCLUDE_CURRENT_DIR ON) set(CMAKE_C_STANDARD 11)...