graphic-walker icon indicating copy to clipboard operation
graphic-walker copied to clipboard

[Discuss] Exported images had no background in dark mode, making the labels hard to recognize

Open Kytscho opened this issue 1 year ago • 3 comments

The image I exported gw chart 913200

Ths is how it looked in my explorer screenshot-20230414-231145

Noticed the background is transparent but image explorers usually make a white background, so that the text contents are hard to recognize. I wonder if there will be an option to control the background, or just to capture the appearance in my browser. thx.

Kytscho avatar Apr 14 '23 15:04 Kytscho

Hi @AntoineYANG, i am new to this project and would love to contribute. Could you kindly help me get started here. Also i have the local dev setup done and good to go.

nc1337 avatar Apr 16 '23 17:04 nc1337

Hi @AntoineYANG, i am new to this project and would love to contribute. Could you kindly help me get started here. Also i have the local dev setup done and good to go.

Glad to have you here @nc1337 ! We encourage contributions and everyone can contribute to this project. You can take and do something with this issue if you'd like to. I assume you have already checked the license and README. So the usual procedure to get contributing is to

  1. Fork the graphic-walker repository.
  2. Commit your code.
  3. Creating a PR from your branch to the main branch, with an introduction to your changes, and cite this issue in it.

Members will check open PRs and keep contacting with contributors.

AntoineYANG avatar Apr 17 '23 12:04 AntoineYANG

Guides for contributors:

The background of visualization is now set by default to transparent in https://github.com/Kanaries/graphic-walker/blob/main/packages/graphic-walker/src/vis/theme.ts

  1. Config can be added to store visualConfig to allow the user to set the background manually.
  2. it might be a good idea to set the theme config to non-transparent value by default

ObservedObserver avatar Apr 25 '23 10:04 ObservedObserver