Rath icon indicating copy to clipboard operation
Rath copied to clipboard

Published 20 hours ago • verified publisher icon Kanaries

[refactor] unnecessary rxjs code

Open ObservedObserver opened this issue 2 years ago • 3 comments

https://github.com/Kanaries/Rath/blob/ed6f3813fdc822a67529cd339a4e49bcb9163097/packages/rath-client/src/pages/dataSource/selection/database/reducer.ts#L9-L386

@AntoineYANG Please refactor all of this. It seems RxJS is unnecessary here. Only use RxJS when you have demands for high-order operators.

ObservedObserver avatar Dec 17 '22 12:12 ObservedObserver

Including causalStore.

ObservedObserver avatar Dec 18 '22 14:12 ObservedObserver

Appreciated. Now focusing on this. 🫡

AntoineYANG avatar Dec 19 '22 02:12 AntoineYANG

will be fixed in 51aa421 and cc2338d

AntoineYANG avatar Dec 19 '22 07:12 AntoineYANG