play-monadic-actions icon indicating copy to clipboard operation
play-monadic-actions copied to clipboard

Published 20 hours ago • verified publisher icon Kanaka-io

Fix compilation issue #44 introduced in v2.2.0

Open marko-asplund opened this issue 4 years ago • 3 comments

Fix issue #44 by reverting comming 0d81d07dc779716627ed2092ec61a417bbfd42ce

ping @vil1

marko-asplund avatar Sep 03 '20 12:09 marko-asplund

Coverage Status

Coverage decreased (-0.1%) to 96.591% when pulling 317645572e24a6de32c688e0b50d638982a8fdb8 on marko-asplund:fix-compilation-issue-44 into 3b3cc3cde458e37b4868d5d8bf5b877236853011 on Kanaka-io:master.

coveralls avatar Sep 03 '20 12:09 coveralls

I won't have time to look at this before this weekend I'm afraid, but I promise I'll do.

vil1 avatar Sep 03 '20 13:09 vil1

I'm reluctant to remove this method completely as it may be used by some client projects.

One could argue that the breaking change was 0d81d07dc779716627ed2092ec61a417bbfd42ce and that this PR only reverts that 😬 .

I'd prefer to explore a non-breaking solution to this problem

🤔 I'm not sure how fBooleanToStepOps can be left there without breaking code using a pre 2.2.0 version. Any ideas?

marko-asplund avatar Sep 08 '20 11:09 marko-asplund