selene icon indicating copy to clipboard operation
selene copied to clipboard

Include global functions in unscoped_variables lint

Open Kampfkarren opened this issue 6 years ago • 1 comments

If they're not already. If they are, add it to the test file.

Kampfkarren avatar Nov 08 '19 23:11 Kampfkarren

We ran into a case recently where this lint would have helped massively. A function accidentally defined globally almost delayed a release for at least a day!

Luckily, when I joined to help I had an extension that highlights globals and locals differently, so it stood out to me. This is something that other team members expected Selene to catch since they'd grown use to it catching so many other global vs local issues.

Corecii avatar Dec 25 '21 16:12 Corecii