Selene tries to update with an explicit path in Settings.json

[Kontoury]

This should be pretty low priority because of the easy fix.

Reproduction steps:

• Download and unzip Selene 0.18.1 or lower
• Set up the Selene path in VSCode
• Restart VSCode You should be getting the notification asking to update Selene.

To fix, simply remove the Path from Settings.json

[akai54]

Hello, I would like to take care of this if it's possible. If anyone can give me an advice on where to start, and which files I should be checking, it would be awesome.

[Kampfkarren]

@akai54 The VSCode extension code is pretty crappy right now, but here's what you'd do:

https://github.com/Kampfkarren/selene/blob/085532a9fa10a409e35477644c091ae5b56fc1b6/selene-vscode/src/util.ts#L164-L169

This is the code that checks for updates.

This is the code for checking an explicit version:

https://github.com/Kampfkarren/selene/blob/085532a9fa10a409e35477644c091ae5b56fc1b6/selene-vscode/src/util.ts#L130-L132

Ideally the first block of code wouldn't be where it is, but that's where it is right now unfortunately. You would wrap that return with the same check for if the setting isn't set.