hoarcekat icon indicating copy to clipboard operation
hoarcekat copied to clipboard

Rewrite Plugin Interface in React

Open Nidoxs opened this issue 1 year ago • 7 comments

As discussed, I've rewritten the legacy Roact code that was powering Hoarcekat's plugin interface.

It may not be perfect just yet, as I did all of this across a few days around university studies.

I will be very happy to take on board any suggestions / requested changes during a review. Let's iterate on this until it's good enough for a merge. 🚀 😄

Thanks!

P.S I will be re-implementing my earlier general improvements changes from #41 after we get this merged onto the mainline.

Nidoxs avatar Oct 25 '23 18:10 Nidoxs

Closes #43

Nidoxs avatar Oct 25 '23 18:10 Nidoxs

Most requested changes have been implemented. Need to handle https://github.com/Kampfkarren/hoarcekat/pull/44#discussion_r1381099712 but once handled, will re-request a review.

Nidoxs avatar Nov 08 '23 02:11 Nidoxs

Looks like there's an issue with Hoarcekat not refreshing when a story script is updated. Will investigate soon.

Nidoxs avatar Nov 15 '23 12:11 Nidoxs

Fixed the aforementioned issue, previewer is working as normal again. Ready for a final review before merging.

Nidoxs avatar Nov 25 '23 16:11 Nidoxs

@chriscerie Hey Chris, thanks a lot for the PR comments! Been pretty busy recently but will get around to this soon.

Nidoxs avatar Dec 17 '23 15:12 Nidoxs

All PR comments have been addressed. Ready for a final review and casual testing before merging.

Nidoxs avatar Jan 02 '24 23:01 Nidoxs

An issue with module requires has been identified, I'll look into it soon. I have been busy with university, hence the staleness of this PR.

Nidoxs avatar May 05 '24 08:05 Nidoxs