boyned//Kampfkarren

Results 313 comments of boyned//Kampfkarren

I think I don't have the ability to run tests on PRs since you don't have the authentication token, I'm going to clone your branch and test it on there.

Your tests failed--#121 Please make a good attempt to run the tests locally. All it should take is: 1. Download the submodules (for TestEZ and MockDataStoreWrapper) 2. Build tests.project.json into...

I'd recommend doing a bisect, removing paths from the project.json until it works, so you know which path in specific is causing the issues. Make sure your Rojo is up...

Request review from me when you have something that works so I can run it on the CI runner.

Reopened since this is a weirder problem than I anticipated. It would require `:BeforeSave` run whether or not it'll actually save or not, which I'm not sure I want.

@LPGhatguy Would that require letting rbx_dom_weak reason about tags? No Rust code in that codebase references Tags at all, wasn't sure if that's an intentional decision or if it's just...

Making a crate for this kind of stuff (attributes *and* tags?) sounds fine to me, especially since it means that other developers could do things like reading attributes/tags in programs...

Yes, though it's waiting on this PR: https://github.com/rojo-rbx/rbx-dom/pull/166

table.freeze is now out, so this is doable. > I don't think we need to support Promise objects in the store. In my own systems, I check `getmetatable(table) ~= nil`...

> 0.5.0 Release Check this one off!