smudgeplot icon indicating copy to clipboard operation
smudgeplot copied to clipboard

Histogram was gone

Open xiekunwhy opened this issue 1 year ago • 8 comments

Hi,

Following this totural (https://github.com/KamilSJaron/smudgeplot/wiki/BGA24), I can't see this plot image

But only a plot without histogram.

Best, Kun

xiekunwhy avatar Nov 28 '24 20:11 xiekunwhy

I should update the plot in the tutorial!!!

Can you please past your plot without histograms here? We removed the histograms in the latest version because no one seems to be using them... A few people asked to add them back. We will, but there are some other priorities first :-)

KamilSJaron avatar Nov 29 '24 15:11 KamilSJaron

Hi, here is mine, can you explain Y-axis in the new plot ?

image

xiekunwhy avatar Nov 30 '24 04:11 xiekunwhy

I also hoping histogram back.

xiekunwhy avatar Nov 30 '24 04:11 xiekunwhy

The y-axis is the same as it used to, but instead of giving you the coverage of the A + B in "1n coverage" units, it gives you the numerical scale. The 2n, ... etc you can tell by labels of smudges.

However, in your case the labels are terribly misplaced, would you mind sharing your smu file? I would like to see how that happened.

KamilSJaron avatar Dec 02 '24 23:12 KamilSJaron

I should update the plot in the tutorial!!!

Can you please past your plot without histograms here? We removed the histograms in the latest version because no one seems to be using them... A few people asked to add them back. We will, but there are some other priorities first :-)

Thanks for the update! I was just wondering whether the histograms have been added back in yet? If not, would you mind letting me know if there’s another way I might go about adding them myself?

xtwang0110 avatar Apr 02 '25 05:04 xtwang0110

Hi Kamil, I vote in favor of having at least a switch to add the histograms to the smudge plot. Best

diriano avatar Apr 08 '25 23:04 diriano

I agree, the histograms are nice as an option. We have also seen an issue with misplaced labels on the smudgeplot, in our case pretty extreme:

Image

cjfields avatar Jun 27 '25 16:06 cjfields

Sorry folks takes so much time, we are working on getting them back.

In fact, @samebdon have implemented them already, but I did manage to break them with some of the toy datasets, so we need to get it stable first and unfortunately have some other priorities now...

KamilSJaron avatar Jun 27 '25 20:06 KamilSJaron

You should now get histograms using the version on the master branch. You can install it with the following code, and you can do this within a conda environment if you want to. You need pip installed. Let me know if there are any problems we are working on the documentation.

OPTIONAL: conda create -n smudgeplot && conda activate smudgeplot conda install pip

Then: git clone https://github.com/KamilSJaron/smudgeplot.git cd smudgeplot && python -m pip install . smudgeplot -h # check it is working

samebdon avatar Jul 02 '25 10:07 samebdon