WolfHUD icon indicating copy to clipboard operation
WolfHUD copied to clipboard

Update PrePlanManager.lua

Open soumaxetuirk opened this issue 4 years ago • 7 comments

crash fix while loading saved preplanning remove overlapping "buy all assets" button.

Description

'_get_type_cost' renamed to 'get_type_cost' 'BuyAllAsset.lua' shoulde be removed as its now implemented by the game 199.6 update.

soumaxetuirk avatar Aug 14 '20 10:08 soumaxetuirk

Probably instead of deleting the BuyAllAsset code altogether we still should use the asset cost calculation stuff so that the functionality stays the same as before (displaying the total cost next to the button text).

Also MenuManager.show_confirm_mission_asset_buy_all = expect_yes should be added to MenuTweaks.lua to skip the dialog

PhantomGamers avatar Aug 14 '20 21:08 PhantomGamers

L796 of MenuTweaks?

bscout9956 avatar Aug 15 '20 18:08 bscout9956

L796 of MenuTweaks?

doesn't matter which order but yes in that location

PhantomGamers avatar Aug 15 '20 22:08 PhantomGamers

You can remove BuyAllAsset.lua and change _get_type_cost to get_type_cost in PrePlanManager.lua by yourself. Also MenuManager.show_confirm_mission_asset_buy = expect_yes is already in MenuTweaks.lua

s193067 avatar Aug 29 '20 14:08 s193067

You're right, it's buy_all, I miswrote that. Updated the comment.

PhantomGamers avatar Aug 30 '20 12:08 PhantomGamers

This is due months, any plans to merge Kamikaze?

bscout9956 avatar Sep 30 '20 19:09 bscout9956

I have forked this project and merged your PR to the fork. It looks like Kamikaze has dropped this project so for now, if you'd like to get this in, you can use this fork until Kamikaze gets back.

https://github.com/wolfhud/WolfHUD

@bscout9956 @TRTSC @PhantomGamers @soumaxetuirk

ghost avatar Nov 10 '20 19:11 ghost