vscode-colorize icon indicating copy to clipboard operation
vscode-colorize copied to clipboard

Color Highlighting just broke

Open 275RR opened this issue 4 years ago • 9 comments

Hello, All color highlighting just broke in my CSS. The color boxes are still working.

colorize

colorize2

Great work on this extension btw. It's awesome!

275RR avatar Jan 15 '21 18:01 275RR

@275RR I've just released a new version with some major changes. Check the release note to see if your config is still valid. For the color boxes, if I remember correctly the setting that control them is color.decorations

KamiKillertO avatar Jan 15 '21 19:01 KamiKillertO

@KamiKillertO Thank you for the response. Please see images above.

-Color decorations are working -Color highlighting / color backgrounds are broken for me with or without variables!

I have the default config, and I have uninstalled/reinstalled the extension. I'm on Windows 10.

Also, if I roll back to v0.8.17, everything is working. If I enable Colorize_only_visible_beta, everything is working.

275RR avatar Jan 16 '21 17:01 275RR

Ok. I'll run some test on windows 10 and try to reproduce

KamiKillertO avatar Jan 16 '21 18:01 KamiKillertO

If you need any more info on my setup, or if you would like me to try anything, let me know. I would be glad to help.

275RR avatar Jan 16 '21 18:01 275RR

Ok, I've managed to reproduce the issue. Unfortunately, I cannot find a way to fix it. For some reasons, vscode on win10 does not behave as vscode on linux. Normally, colorize get all extensions installed on vscode and match them with the list of languages listed in the setting colorize.languages to get a list of file extensions to search variables in. But, on windows 10 the built-in extensions are not exposed 😒. As a result CSS ans SASS variables are not extracted.

If you want to have the variables extracted by default for css you need to add "**/*.css" in the colorize.include setting.

I've also released a new version who search for variables in *.css,*.scss,*.sass,*.less files by default. I'm planning on improving this part in future releases to help identify which files are red during variables extraction.

KamiKillertO avatar Jan 17 '21 13:01 KamiKillertO

@KamiKillertO Thanks, this is the best extension for CSS on vscode.

  1. I checked another win10 machine and everything is working now with the hotfix including CSS variables.
  2. For my machine, I found that the Tabnine AI extension is conflicting with this Colorize update. If I disable Tabnine, Colorize works.

Should I close this issue or leave this open until future improvements for variable extraction?

275RR avatar Jan 17 '21 16:01 275RR

No that's ok you can keep this issue open. I'll run some tests with tabnine AI to found what the problem is

KamiKillertO avatar Jan 17 '21 16:01 KamiKillertO

I've fixed the issue with Tabnine 👍

KamiKillertO avatar Jan 18 '21 08:01 KamiKillertO

Re-enabled Tabnine. No issues!

275RR avatar Jan 18 '21 14:01 275RR