Kamforka

We are closing this issue as it pertains to the 1.x version of thehive4py, which is no longer supported. We recommend upgrading to the latest release for continued support or...

This is done in a different way via 2.x

@wizedkyle is this feature still relevant to you or you moved to v5 in the meantime?

We are closing this PR as it targets the 1.x version of thehive4py, which is no longer supported.

Closing this as this functionality is already present in 2.x and 1.x is not supported anymore

Hi TytoCapensis! Very nice suggestion! My original idea was to overload the `download_path` variable so it can be a pathlike parameter or an IO buffer. I think that would be...

Thank you for your changes @TytoCapensis , I'll find time to review them. But by just looking at your comment I might argue with the type ignore as I'm afraid...

That's because you're using: ```python if type(download_path) is BytesIO ``` Which is not recognized by mypy properly, a more conventional method (which will also get rid of the type hinting...

Also it might make sense to create a module e.g. in `types/_common.py` and collect the common type definitions there, so we can get rid of the repetition of this path/buffer...

I've reworked the integration test setup. Can you please rebase on the latest main branch to check how it works out?