vscode-cfml icon indicating copy to clipboard operation
vscode-cfml copied to clipboard

fix lineCharacterOffset generating a negative value

Open maverck opened this issue 4 years ago • 4 comments

lineCharacterOffset = lineText.length - 1;

this line results in a negative value sometimes? and the extension crashes and no longer provides completion. I clamped the value so it can't be negative.

maverck avatar Jun 16 '20 01:06 maverck

Can this be merged , this seems to prevent issues where I have to restart VSCode to resolve them currently

ghedwards avatar Nov 24 '20 22:11 ghedwards

Ping!? could this be merged ?

ghedwards avatar May 08 '21 11:05 ghedwards

@KamasamaK just wondering if you saw this merge request?

pczarn2 avatar Feb 01 '23 16:02 pczarn2

This is fixed in my latest fork https://github.com/garethedwards-tass/vscode-cfml turns out the fix was more involved than this specific change

garethedwards-tass avatar Dec 12 '23 06:12 garethedwards-tass