gogrepoc icon indicating copy to clipboard operation
gogrepoc copied to clipboard

Won't download games, only bonuses

Open bensuperpc opened this issue 3 years ago • 12 comments

I tested with the last version (master). It does not download the games but only the bonuses.

I am using linux (Manjaro 21.2.0) and python 3.9

I used these commands (without error):

gogrepoc.py login
gogrepoc.py update
gogrepoc.py download
gogrepoc.py verify

Games:

The Terraria game is missing for example, there are only bonuses:

python gogrepoc.py download -ids terraria                                                                                                                                                                                                                                 127 ✘ 
07:39:14 | loading local manifest...
07:39:14 | downloading games with id(s): {terraria}
07:39:14 | scanning manifest for renames...
07:39:14 | Cleaning up ./!downloading
07:39:14 | {terraria}
07:39:15 |      pass       terraria_soundtrack_vol_1_mp3.zip
07:39:15 |      pass       terraria_soundtrack_vol_2_mp3.zip
07:39:15 | nothing to download
07:39:15 | --
07:39:15 | total time: 0:00:00.398467
07:39:15 | exiting...

The script has nothing to download with metro 2033 redux:

python gogrepoc.py download -ids metro_2033_redux                                                                                                                                                                                                                             ✔ 
07:40:36 | loading local manifest...
07:40:36 | downloading games with id(s): {metro_2033_redux}
07:40:36 | scanning manifest for renames...
07:40:36 | Cleaning up ./!downloading
07:40:36 | {metro_2033_redux}
07:40:36 | nothing to download
07:40:36 | --
07:40:36 | total time: 0:00:00.046324
07:40:36 | exiting...

Maybe I misunderstood something ?

bensuperpc avatar Nov 30 '21 06:11 bensuperpc

I believe there's an os detection error on Linux that I need to look into. Try specificying -os linux or -os mac as appropriate for your OS.

On Tue, 30 Nov 2021, 16:44 Bensuperpc, @.***> wrote:

I tested with the last version (master). It does not download the games but only the bonuses.

I used these commands (without error):

gogrepoc.py login

gogrepoc.py update

gogrepoc.py download

gogrepoc.py verify

Games:

The Terraria game is missing for example, there are only bonuses:

python gogrepoc.py download -ids terraria  127 ✘

07:39:14 | loading local manifest...

07:39:14 | downloading games with id(s): {terraria}

07:39:14 | scanning manifest for renames...

07:39:14 | Cleaning up ./!downloading

07:39:14 | {terraria}

07:39:15 | pass terraria_soundtrack_vol_1_mp3.zip

07:39:15 | pass terraria_soundtrack_vol_2_mp3.zip

07:39:15 | nothing to download

07:39:15 | --

07:39:15 | total time: 0:00:00.398467

07:39:15 | exiting...

The script has nothing to download with metro 2033 redux:

python gogrepoc.py download -ids metro_2033_redux  ✔

07:40:36 | loading local manifest...

07:40:36 | downloading games with id(s): {metro_2033_redux}

07:40:36 | scanning manifest for renames...

07:40:36 | Cleaning up ./!downloading

07:40:36 | {metro_2033_redux}

07:40:36 | nothing to download

07:40:36 | --

07:40:36 | total time: 0:00:00.046324

07:40:36 | exiting...

Maybe I misunderstood something ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Kalanyr/gogrepoc/issues/50, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKZ3323K6L3UDOQ2OMO7SDUORXELANCNFSM5JA7GERA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Kalanyr avatar Nov 30 '21 06:11 Kalanyr

I believe there's an os detection error on Linux that I need to look into. Try specificying -os linux or -os mac as appropriate for your OS.

It does not work :/

With linux settings:

python gogrepoc.py update -os linux                                                                                                                                ✔ 
07:50:39 | loading local manifest...
07:50:39 | loading local resume manifest...
07:50:39 | fetching game product data (page 1)...
07:50:40 | no new game or updates found.
07:50:40 | --
07:50:40 | total time: 0:00:00.399320
07:50:40 | exiting...
python gogrepoc.py update -os linux -lang en de -id terraria                                                                                                ✔  7s  
07:58:06 | loading local manifest...
07:58:06 | loading local resume manifest...
07:58:06 | fetching game product data (page 1)...
07:58:06 | scanning found "terraria" in product data!
07:58:06 | saving resume manifest...
07:58:06 | saved resume manifest
07:58:06 | (1 / 1) fetching game details for terraria...
07:58:09 | saving manifest...
07:58:09 | saved manifest
07:58:09 | saving resume manifest...
07:58:09 | saved resume manifest
07:58:09 | --
07:58:09 | total time: 0:00:02.951428
07:58:09 | exiting...

With windows settings:

python gogrepoc.py update -os windows -lang en de -id terraria                                                                                                  
07:53:16 | loading local manifest...
07:53:16 | loading local resume manifest...
07:53:16 | fetching game product data (page 1)...
07:53:16 | scanning found "terraria" in product data!
07:53:16 | saving resume manifest...
07:53:16 | saved resume manifest
07:53:16 | (1 / 1) fetching game details for terraria...
07:53:20 | saving manifest...
07:53:20 | saved manifest
07:53:20 | saving resume manifest...
07:53:20 | saved resume manifest
07:53:20 | --
07:53:20 | total time: 0:00:04.129629
07:53:20 | exiting...

bensuperpc avatar Nov 30 '21 06:11 bensuperpc

Those update commands are doing radically different things , your first command is looking for any game that has been marked as updated or isn't present in your manifest and that has a Linux version and updating it (so it won't do anything if Terraria is up to date).

Your second is forcing an update of Terraria if it is in your GOG collection, has an English or Deutsch version and has a windows version (and the last two are true for Terraria so it will always force an update).

On Tue, 30 Nov 2021, 16:54 Bensuperpc, @.***> wrote:

I believe there's an os detection error on Linux that I need to look into. Try specificying -os linux or -os mac as appropriate for your OS.

It does not work :/

python gogrepoc.py update -os linux  ✔

07:50:39 | loading local manifest...

07:50:39 | loading local resume manifest...

07:50:39 | fetching game product data (page 1)...

07:50:40 | no new game or updates found.

07:50:40 | --

07:50:40 | total time: 0:00:00.399320

07:50:40 | exiting...

python gogrepoc.py update -os windows -lang en de -id terraria

07:53:16 | loading local manifest...

07:53:16 | loading local resume manifest...

07:53:16 | fetching game product data (page 1)...

07:53:16 | scanning found "terraria" in product data!

07:53:16 | saving resume manifest...

07:53:16 | saved resume manifest

07:53:16 | (1 / 1) fetching game details for terraria...

07:53:20 | saving manifest...

07:53:20 | saved manifest

07:53:20 | saving resume manifest...

07:53:20 | saved resume manifest

07:53:20 | --

07:53:20 | total time: 0:00:04.129629

07:53:20 | exiting...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Kalanyr/gogrepoc/issues/50#issuecomment-982338235, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKZ33675M7R7G67WWPRMJDUORYKBANCNFSM5JA7GERA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Kalanyr avatar Nov 30 '21 07:11 Kalanyr

Those update commands are doing radically different things , your first command is looking for any game that has been marked as updated or isn't present in your manifest and that has a Linux version and updating it (so it won't do anything if Terraria is up to date). Your second is forcing an update of Terraria if it is in your GOG collection, has an English or Deutsch version and has a windows version (and the last two are true for Terraria so it will always force an update).

It was more to test, after having tested several commands, it finally downloaded the game, but impossible to download the windows or macos version :/

With the same commands as on the first post:

python gogrepoc.py download -ids terraria                                                                                                                           ✔ 
08:07:50 | loading local manifest...
08:07:50 | downloading games with id(s): {terraria}
08:07:50 | scanning manifest for renames...
08:07:50 | Cleaning up ./!downloading
08:07:50 | {terraria}
08:07:50 |      pass       terraria_v1_4_3_2_51716.sh
08:07:50 |      pass       terraria_soundtrack_vol_1_mp3.zip
08:07:50 |      pass       terraria_soundtrack_vol_2_mp3.zip
08:07:50 | nothing to download
08:07:50 | --
08:07:50 | total time: 0:00:00.047533
08:07:50 | exiting...

UPDATE:

And not working anymore after several commands:

python gogrepoc.py download -ids terraria                                                                                                                          ✔ 
08:18:53 | loading local manifest...
08:18:54 | downloading games with id(s): {terraria}
08:18:54 | scanning manifest for renames...
08:18:54 | Cleaning up ./!downloading
08:18:54 | {terraria}
08:18:54 |      pass       terraria_soundtrack_vol_1_mp3.zip
08:18:54 |      pass       terraria_soundtrack_vol_2_mp3.zip
08:18:54 | nothing to download
08:18:54 | --
08:18:54 | total time: 0:00:00.047918
08:18:54 | exiting...

I'm not sure why, I'll try to dig deeper a bit later

bensuperpc avatar Nov 30 '21 07:11 bensuperpc

If you want multiple versions you should specify eg -os windows linux for both update and download. Update (should) default to the detected system OS and download (should) default to all OSs currently in the manifest for each game its trying to download.

On Tue, 30 Nov 2021, 17:14 Bensuperpc, @.***> wrote:

Those update commands are doing radically different things , your first command is looking for any game that has been marked as updated or isn't present in your manifest and that has a Linux version and updating it (so it won't do anything if Terraria is up to date). Your second is forcing an update of Terraria if it is in your GOG collection, has an English or Deutsch version and has a windows version (and the last two are true for Terraria so it will always force an update).

It was more to test, after having tested several commands, it finally downloaded the game, but impossible to have the windows version :/

With the same commands as on the first post:

python gogrepoc.py download -id terraria  ✔

08:07:50 | loading local manifest...

08:07:50 | downloading games with id(s): {terraria}

08:07:50 | scanning manifest for renames...

08:07:50 | Cleaning up ./!downloading

08:07:50 | {terraria}

08:07:50 | pass terraria_v1_4_3_2_51716.sh

08:07:50 | pass terraria_soundtrack_vol_1_mp3.zip

08:07:50 | pass terraria_soundtrack_vol_2_mp3.zip

08:07:50 | nothing to download

08:07:50 | --

08:07:50 | total time: 0:00:00.047533

08:07:50 | exiting...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Kalanyr/gogrepoc/issues/50#issuecomment-982349199, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKZ3376NIVK3NJ6KHORBOLUOR2VZANCNFSM5JA7GERA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Kalanyr avatar Nov 30 '21 07:11 Kalanyr

Could you leave this open please ? Will remind me to look into why the OS detection is broken on Linux.

On Wed, 1 Dec 2021, 08:44 Bensuperpc, @.***> wrote:

Closed #50 https://github.com/Kalanyr/gogrepoc/issues/50.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Kalanyr/gogrepoc/issues/50#event-5695177698, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKZ33YK6ENZ5CYBNDZOR2DUOVHTLANCNFSM5JA7GERA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Kalanyr avatar Nov 30 '21 22:11 Kalanyr

I found a software that works under linux to download all the games, DLC ect ... If that can help you: https://github.com/Sude-/lgogdownloader

bensuperpc avatar Nov 30 '21 22:11 bensuperpc

I was trying to download a game on Windows, and I got the same issue. Only the extras are downloading:

E:\gog\gogrepoc.py download -skipextras -ids agatha_christie_the_abc_murders
12:42:48 | loading local manifest...
12:42:49 | downloading games with id(s): {agatha_christie_the_abc_murders}
12:42:49 | scanning manifest for renames...
12:42:49 | Cleaning up .\!downloading
12:42:49 | {agatha_christie_the_abc_murders}
12:42:49 | nothing to download
12:42:49 | --
12:42:49 | total time: 0:00:00.664767
12:42:49 | exiting...

The Manifest file is empty in the downloads section for this game. Only the extras have the URLs.

Edit: Looking at the Manifest file, it seems that the downloads section is empty for a lot of my games. If the game is only available in English, and the downloads section is empty, then nothing will be downloaded.

Here is part of the Alan Wake entry in the manifest file:

 'downloads': [],
  'extras': [{'desc': 'manual',
              'href': 'https://www.gog.com/downloads/alan_wake/14253',
              'lang': '',
              'md5': None,
              'name': 'alan_wake_manual.zip',

And the output of trying to download the game:

[E:\gog]gogrepoc.py download -skipextras -ids alan_wake
14:15:50 | loading local manifest...
14:15:51 | downloading games with id(s): {alan_wake}
14:15:51 | scanning manifest for renames...
14:15:51 | Cleaning up .\!downloading
14:15:51 | {alan_wake}
14:15:51 | nothing to download
14:15:51 | --
14:15:51 | total time: 0:00:00.667905
14:15:51 | exiting...

juanmbt avatar Jan 12 '22 18:01 juanmbt

Can you try

gogrepoc.py update -os windows -lang en -full And then gogepoc.py download "YourTargetDirectoryHere" -os windows -lang en

On Thu, 13 Jan 2022, 04:44 Juan M, @.***> wrote:

I was trying to download a game on Windows, and I got the same issue. Only the extras are downloading:

E:\gog\gogrepoc.py download -skipextras -ids agatha_christie_the_abc_murders 12:42:48 | loading local manifest... 12:42:49 | downloading games with id(s): {agatha_christie_the_abc_murders} 12:42:49 | scanning manifest for renames... 12:42:49 | Cleaning up .!downloading 12:42:49 | {agatha_christie_the_abc_murders} 12:42:49 | nothing to download 12:42:49 | -- 12:42:49 | total time: 0:00:00.664767 12:42:49 | exiting...

— Reply to this email directly, view it on GitHub https://github.com/Kalanyr/gogrepoc/issues/50#issuecomment-1011346091, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKZ3326AKNNJ2H7KSQ4OPDUVXDZPANCNFSM5JA7GERA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

Kalanyr avatar Jan 12 '22 23:01 Kalanyr

Can you try gogrepoc.py update -os windows -lang en -full And then gogepoc.py download "YourTargetDirectoryHere" -os windows -lang en On Thu, 13 Jan 2022, 04:44 Juan M, @.> wrote: I was trying to download a game on Windows, and I got the same issue. Only the extras are downloading: E:\gog\gogrepoc.py download -skipextras -ids agatha_christie_the_abc_murders 12:42:48 | loading local manifest... 12:42:49 | downloading games with id(s): {agatha_christie_the_abc_murders} 12:42:49 | scanning manifest for renames... 12:42:49 | Cleaning up .!downloading 12:42:49 | {agatha_christie_the_abc_murders} 12:42:49 | nothing to download 12:42:49 | -- 12:42:49 | total time: 0:00:00.664767 12:42:49 | exiting... — Reply to this email directly, view it on GitHub <#50 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKZ3326AKNNJ2H7KSQ4OPDUVXDZPANCNFSM5JA7GERA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.Message ID: @.>

Hi,

What worked for me was, delete the manifest file, and run the first command you suggested (non including -full): gogrepoc.py update -os windows -lang en

The newly generated manifest file, now has the correct download links for the English version of the games. I was able to download the games I was having problems before.

Thanks.

juanmbt avatar Jan 13 '22 18:01 juanmbt

I faced exactly the same problem. Made a workaround as per @Kalanyr comment above. First script: login.sh

#!/bin/sh
set -e
GOGREPOC="python3 $PWD/gogrepoc/gogrepoc.py"
GOGCRED="$1 $2"
$GOGREPOC login $GOGCRED

Second script: update.sh

#!/bin/sh
set -e
GOGREPOC="python3 $PWD/gogrepoc/gogrepoc.py"
PLATFORMS="mac linux windows"
for platform in mac linux windows
do
  mkdir -p $platform
  cp gog-cookies.dat $platform/
  cd $platform
  $GOGREPOC update -os $platform -lang en ru
  $GOGREPOC download -os $platform -skipextras
  $GOGREPOC verify -os $platform -skipextras
  cd ..
done

mkdir -p extras
cp gog-cookies.dat extras/
cd extras
$GOGREPOC update -lang en ru
$GOGREPOC download -os $platform -skipgames
$GOGREPOC verify -os $platform -skipgames
cd ..

Just set python script location to GOGREPOC, then run login.sh with login and password (no quotes, space separated), then call update.sh from same folder.

Scripts are pretty self descriptive, and appear to be working.

znoxx avatar Apr 04 '22 07:04 znoxx

This PR https://github.com/Kalanyr/gogrepoc/pull/83 does not fix the issue, but adds a workaround to support for multiple os and lang arguments to update and download. Not a fix, but might give someone a hint on what's actually not working in Linux.

Sta2s avatar Jan 08 '23 12:01 Sta2s