gogrepoc icon indicating copy to clipboard operation
gogrepoc copied to clipboard

Empty downloads property

Open Tangeek42 opened this issue 4 years ago • 7 comments

Hi.

Haven't seen this in the issues, and I am not willing to read 125 pages on the GOG forum, so please excuse me if this is ovious. Just tried from a completely new folder and clean slate, still doing this.

python3 ../gogrepoc.py login python3 ../gogrepoc.py update -full python3 ../gogrepoc.py download -dryrun

It reports nothing but the extras to download (I have 147 games, they cannot just be 48G :D ). The manifest seems to be missing the URL to download the game itself: 'downloads': [],

Every game has this issue.

Is this something I messed up on the CLI or python dependencies ?

EDIT: Should point out I'm using the dev branch. gogrepoc.py (version 0.4.0-a)

Tangeek42 avatar Dec 22 '20 06:12 Tangeek42

Try using -os and -lang to specify a language/os both for update and download. I'm guessing the auto-detect isn't working for some reason for you .

On Tue, 22 Dec 2020, 16:46 Tangeek, [email protected] wrote:

Hi.

Haven't seen this in the issues, and I am not willing to read 125 pages on the GOG forum, so please excuse me if this is ovious. Just tried from a completely new folder and clean slate, still doing this.

python3 ../gogrepoc.py login python3 ../gogrepoc.py update -full python3 ../gogrepoc.py download -dryrun

It reports nothing but the extras to download (I have 147 games, they cannot just be 48G :D ). The manifest seems to be missing the URL to download the game itself: 'downloads': [],

Every game has this issue.

Is this something I messed up on the CLI or python dependencies ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Kalanyr/gogrepoc/issues/36, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKZ33YPMOQQLV762NVY6OLSWA6C5ANCNFSM4VFGTJFQ .

Kalanyr avatar Dec 22 '20 08:12 Kalanyr

Actually I tried it first (-os windows linux -lang fr en) at both update and download. Then I assumed I did it wrong, erased everything and tried in an empty folder what I pasted in the first post.

Is there a debug output I could look into ?

Tangeek42 avatar Dec 22 '20 09:12 Tangeek42

OK just tried with "-os windows -lang en" and the URL seem to be there. I must have not understood how to specify several os/languages and that's why my first try didn't work, that's fine by me. I'll do two seperate folders for the two OSes.

But just FYI, tried again without specifying anything, just to be sure, completely from scratch again, and the bug was still there. So I guess you're right, the auto-detect isn't working. I would suggest setting a default in the code with Windows/Eng since it's the most used ?

I'll be happy to give you more info about my CLI/Python environment if you want to look into it, but I don't know jack about Python so I don't know what is useful to debug. The OS is a Debian based NAS, several versions of Python are installed but I call directly python3, which has the modules specified in the ReadMe installed.

I could take a while to reply as of now, since I'm about to download 2TB of games. :D

Tangeek42 avatar Dec 22 '20 09:12 Tangeek42

It does auto-detect lang / os and falls back to Eng/Win , I suspect the detection is bugged for Linux systems and will look into it.

Thanks.

On Tue, 22 Dec 2020, 19:53 Tangeek, [email protected] wrote:

OK just tried with "-os windows -lang en" and the URL seem to be there. I must have not understood how to specify several os/languages and that's why my first try didn't work, that's fine by me. I'll do two seperate folders for the two OSes.

But just FYI, tried again without specifying anything, just to be sure, completely from scratch again, and the bug was still there. So I guess you're right, the auto-detect isn't working. I would suggest setting a default in the code with Windows/Eng since it's the most used ?

I'll be happy to give you more info about my CLI/Python environment if you want to look into it, but I don't know jack about Python so I don't know what is useful to debug. The OS is a Debian based NAS, several versions of Python are installed but I call directly python3, which has the modules specified in the ReadMe installed.

I could take a while to reply as of now, since I'm about to download 2TB of games. :D

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Kalanyr/gogrepoc/issues/36#issuecomment-749454695, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKZ3325COCXGP77EKV7HLDSWBUBNANCNFSM4VFGTJFQ .

Kalanyr avatar Dec 22 '20 14:12 Kalanyr

Before using your fork, I was using the original from a few years ago. Now that I think about it, it was downloading the Windows versions without me having to specify it, so maybe the issue is inherited from there. Could be my system.

Tangeek42 avatar Dec 22 '20 14:12 Tangeek42

The old version doesn't auto-detect at all it just defaults to Win / En and you have to override for other OS / Lang.

On Wed, 23 Dec 2020, 00:23 Tangeek, [email protected] wrote:

Before using your fork, I was using the original from a few years ago. Now that I think about it, it was downloading the Windows versions without me having to specify it, so maybe the issue is inherited from there. Could be my system.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Kalanyr/gogrepoc/issues/36#issuecomment-749563903, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKZ33ZKRQMKVG2AZVUTAWTSWCTVLANCNFSM4VFGTJFQ .

Kalanyr avatar Dec 22 '20 14:12 Kalanyr

My bad then. I'll leave you to it. Don't hesitate to ask me info about my setup if you need it. On a side note, thanks for your work. I'm overjoyed that it doesn't take a full night anymore to download the manifest. ^^

Tangeek42 avatar Dec 22 '20 14:12 Tangeek42