Atari icon indicating copy to clipboard operation
Atari copied to clipboard

Implement optimality tightening

Open Kaixhin opened this issue 8 years ago • 8 comments

Learning to Play in a Day: Faster Deep Reinforcement Learning by Optimality Tightening potentially speeds up Q-learning by an order of magnitude! Apparently not too hard to implement either.

Kaixhin avatar Dec 11 '16 21:12 Kaixhin

I gave it a shot, however I am not sure how the discounted reward R is supposed to be used and I also need to check if future and past k-transitions are valid

https://github.com/petrosgk/Atari/tree/opt-tightening

petrosgk avatar Dec 15 '16 21:12 petrosgk

Awesome - I'll try and have a look soon or next week! Would you be able to test it to try and replicate one of the results from the paper?

I started on this myself as well, so will see how our implementations compare.

Kaixhin avatar Dec 16 '16 00:12 Kaixhin

Hi, have you reproduced that optimality tightening results? I have tried some games based on tensorflow and openai gym but the results seem much worse than the papers' results. I am not sure whether I misunderstand something or miss some tricks in the paper. It seems that the paper doesn't include everything about their works.

Aeroone avatar Feb 16 '17 00:02 Aeroone

Does anyone know wether they have published the source code for optimal tightening, from the paper?

DanielTea avatar Feb 16 '17 00:02 DanielTea

No, they haven't published their code as far as I know. The tricks they use are not hard to implement but I can not still achieve their performance.

Aeroone avatar Feb 16 '17 00:02 Aeroone

I have tried implementing optimality tightening (see earlier post) but the results I get are also much worse than the paper's.

petrosgk avatar Feb 16 '17 01:02 petrosgk

In my experience the smallest details in a paper can be key to reproducing results - and these may be missing or ambiguous. If anyone is reasonably confident in their implementation, you should try contacting one of the authors with specific questions.

Kaixhin avatar Feb 16 '17 09:02 Kaixhin

Hi guys, I have released the code at https://github.com/ShibiHe/Q-Optimality-Tightening. Please have a look.

Best, Shibi

ShibiHe avatar Apr 25 '17 12:04 ShibiHe