Kaiserreich-DH icon indicating copy to clipboard operation
Kaiserreich-DH copied to clipboard

Some optimizations, minor bugfixs, general cleanup.

Open Arcangelus opened this issue 2 years ago • 0 comments

Annexations.txt:

  • Compressed most of the triggers (removed redundancies).
  • Increased use of secedearea/secederegion where appropriate.
  • Use of add_core_area/region and add_claim_area/region where appropriate.
  • Use of remove_core_area/region and remove_claim_area/region where appropriate.
  • Combined some redundant events.
  • Fixed an issue with Russian cores (There were 2 provinces excluded for no good reason, likely an oversight).
  • Fixed some typos.
  • The decision "The Annexation of Finland" has a clause for Russia/Soviets that can't happen. Commented out.
  • The event "The Annexation of Afghanistan" has a command for the tags IND, PAK, PRK. Neither of those 3 are valid targets of this event. Commented out.

generic_decision.txt

  • The decisions Women Work, War Bonds can now trigger once per country rather than once per game. I assume that was an oversight.
  • The decision "Convert Convoys Into Transports" deducted 500 money twice. Changed the second to supplies, as the trigger seems to suggest that was the intent.
  • The investment decisions now use extended flags. Functionally identical.

Startup.txt

  • Changed the welcoming event to a decision. It gets aggravating after the 10th restart.

Cores.txt

  • Use of add_core_area/region where appropriate.
  • Changed event 966613 to be a little more clear.

Unifications.txt

  • Use of add_core_area/region where appropriate
  • Events 440003-440005 "A proposal from the South" combined into a single one (AI weights unchanged).
  • Peaceful Italian unification now lets the senior part inherit the troops of the junior part (440006, 440013).

Olympics - 1936.txt

  • Small optimization of the "Beginning of the Spartakiade!"/"Ending of the Spartakiade!" events.
  • Fixed typo.

Some observations:

  • The decision "Convert Convoys Into Transports" seems a little too expensive to use as anything but an emergency measure.
  • Creating the "Republic of China" breaks the "Fate of X China" decisions a little, as that nation has cores on the whole region, plus claims to Mongolia.
  • "The fate of Japan" can grant cores on the Sakhalin/Kuriles Islands to any nation.
  • It has been a while since I last used Github. I apologize if I happened to make duplicates of this.

Arcangelus avatar Oct 25 '22 02:10 Arcangelus