PhySG icon indicating copy to clipboard operation
PhySG copied to clipboard

Implementation Question

Open Crane-YU opened this issue 1 year ago • 1 comments

Hi @Kai-46, In your actual implementation of the lobe sharpness in Eq. (8) in the figure below, why do you treat the half angle vector $\mathbf{h}$ the same as lobe axis in L185?

Screenshot from 2022-10-17 23-43-22

Crane-YU avatar Mar 31 '23 14:03 Crane-YU

I read the paper and compared it to the implementation, leading to the exact the same question as asked by @Crane-YU. What I could already find out by checking the code is that the halfway vector stored in new_half is just the surface normal, since warpBrdfSGLobes is the reflexion of the view vector w.r.t. the normal, so taking warpBrdfSGLobes + viewdirs is again the normal. I really do not understand why this is done like that, is it possible to get more information on that?

Exception1984 avatar Aug 29 '23 10:08 Exception1984