Kağan Can Şit

Hello again Mr. @reneme, I included the commit that I made improvements for the function I mentioned in the comment above, which I did not change, in the branch here....

I have addressed all feedback from the review: - Changes to `src/lib/modes/xts/xts.cpp` have been rolled back as suggested to avoid conflicts with upcoming modernizations (#4880, #4151) - Retained deprecation warnings...

> Looks good to me. Thanks for your efforts. Thank you for your time and for sharing your expertise. Your guidance has been very helpful throughout this process. I’ll need...

> Sorry for the wait here. Changes are generally fine but the issue is mem_ops.h is currently a public header _but_ I don't think the library should be in the...

> Given that this PR doesn't add any functionality to `mem_ops.h`, I would suggest the following steps : > > 1. Let's change the deprecation messages in `mem_ops.h` from _"This...

Hmm, Some checks failed 1 failed, 40 passed ```bash src/lib/utils/socket/socket_udp.cpp checked src/lib/utils/socket/socket_udp.cpp:75:21: warning: unnecessary explicit cast to same type as subexpression (i.e. 'unsigned int'), remove this cast [readability-redundant-casting] 75 |...

Thank you for your time. I looked into this situation afterwards, but forgot to write it. The type of res->ai_addrlen from getaddrinfo differs depending on the operating system: > POSIX...

My thoughts were also in this direction for adaptability and readability. However, I did not want to edit it in a way that would ignore a finding that occurred as...

The conflict `src/lib/utils/socket/socket_udp.cpp` was resolved by re-basing the branch with the master branch.

Thanks, @reneme. Your guidance was extremely helpful. I reviewed and updated my ninja and ccache tools: `sudo apt-get upgrade ninja-build` `sudo apt-get upgrade ccache` Then, after compiling the project, I...