Comparison picking up redundant (null?) changes

[PirateIzzy]

I've noticed that in my comparisons, the Comparer picks up a lot of redundant changes like so:

I'm not sure if anything actually changed with these, but I didn't see anything obvious.

[PirateIzzy]

In addition, I noticed that the Comparison lists all of these as changed, but most of them don't have any changes to show at all, and don't link to an actual section.

The QuestInfo\reward\exp values also show as changed despite being the same value and same type:

[Kagamia]

I'll try to explain one by one:

1. It is due to the absense of Equals function on these types, and needs a fix.
2. N*xon introduced Pages field to all existing Canvas objects so you can see the img checksum also changed after the latest patch, but comparer does not account for the change. (now it is by design)
3. Value type changed from int32 to int64.

[PirateIzzy]

For 3, is it possible to convert from int32 to int64 before the comparison, or is that out of the scope of this issue?

[Kagamia]

@PirateIzzy Yes that could be a candidate solution. But it can't cover all cases that NX may change int32 to int64 or string or float type with the same literal value.

I prefer to also print type change if possible.

[PirateIzzy]

Up to you if you want to print type change.

[Kagamia]

The lastest commit should address all of the issues mentioned above (but not tested).

[PirateIzzy]

So I integrated it into my build to test it out, and also tested your build. These are my findings:

Old version (my build):

New version (your build):

New version (my build):

I'm not sure why my latest build has 1 0 appended at the end, as it wasn't present before.

[HikariCalyx]

With @HikariCalyx 's JMS build:

Additionally, non-image entries also have extra numbers added:

The issue specified to KMS fork is fixed with this commit: https://github.com/HikariCalyx/WzComparerR2-JMS/commit/b75a406858ba584703779575a99f3f4762407f18