WzComparerR2 icon indicating copy to clipboard operation
WzComparerR2 copied to clipboard

Halloween related assets don't render properly in KMS 1.2.370

Open HikariCalyx opened this issue 2 years ago • 28 comments

Affected maps: Henesys, Leafre and Nameless Town. image image image

HikariCalyx avatar Nov 13 '22 02:11 HikariCalyx

I don't have installed KMS client, also I can't see halloween elements in KMST 1147. Is it only included in KMS?

Kagamia avatar Nov 13 '22 06:11 Kagamia

Yes, Halloween assets weren't present in KMST 1.2.1147, only included in KMS.

HikariCalyx avatar Nov 13 '22 09:11 HikariCalyx

實際遊戲 運用光影渲染元素,不曉得會不會實現。

lowrt avatar Nov 14 '22 05:11 lowrt

I've downloaded KMS client. Amazing! but it is far more complex than I thought. I see light section but don't know how to make it work. Do we have more screenshots or videos? image

Kagamia avatar Nov 14 '22 16:11 Kagamia

https://youtu.be/2xZLvReSmZk?t=9707

HikariCalyx avatar Nov 14 '22 16:11 HikariCalyx

https://youtu.be/2xZLvReSmZk?t=9707

Cool. Many thanks.

Kagamia avatar Nov 14 '22 16:11 Kagamia

KMS 1.2.372 introduced Christmas themed assets which behave similarly.

image

nanochromatic avatar Dec 22 '22 07:12 nanochromatic

https://youtu.be/TSqFZ7mNYmw?t=65 in-game behavior as reference

HikariCalyx avatar Dec 23 '22 06:12 HikariCalyx

Thanks for acknowledgement, really helps.

As it is the end of year, the deployment progress may be delayed for a long time. We don't have an ETA for the fix. (Believe me it is on the way)

Kagamia avatar Dec 23 '22 06:12 Kagamia

After I use updated HaCreator I think I know what those black tiles were. image

White part on these black tiles were used for glowing effect.

HikariCalyx avatar Jan 15 '23 15:01 HikariCalyx

image the recent commit fixes the glowing object.

Still want some more clear screenshot (not only capture from videos) for global light rendering. I got into trouble on global lighting simulation.

Kagamia avatar Jan 31 '23 15:01 Kagamia

Here you go. Didn't find any ss regarding to Christmas yet. 1 2

Also the BGM mentioned in MapCode.img\info\bgmSub\<randomCode>\uol will be played in game instead.

HikariCalyx avatar Feb 01 '23 03:02 HikariCalyx

Just a follow-up with this issue: Now glowing items don't look right. image

For your convenience, here are 100000000.img, 240000000.img and 450001000.img with Halloween assets - load them along with CMS v201 client.

100000000_halloween.zip 240000000_halloween.zip 450001000_halloween.zip

HikariCalyx avatar Sep 26 '23 04:09 HikariCalyx

@HikariCalyx ack. Not sure if it is a regression, will take a look this week.

Kagamia avatar Sep 26 '23 07:09 Kagamia

Can you take a screenshot in game?
Someone tell me that CMS 201 has not enabled halloween event, curious where you get the client file.

Kagamia avatar Sep 26 '23 07:09 Kagamia

Can you take a screenshot in game? Someone tell me that CMS 201 has not enabled halloween event, curious where you get the client file.

Open CMS v201 client, then open these 3 img files individually. After that, click 450001000.img inside of list, and click MapRenderer.

I know Halloween related assets are present in CMS v201 but not enabled, so loading individual img files will enable them. You can also do this with MSEA client.

HikariCalyx avatar Sep 26 '23 07:09 HikariCalyx

The operation is meaningless.

A merged client is not a Complete client, it is equivalent to a self-modified version or a private server, which is not considered by wcR2's scope of support.

Kagamia avatar Sep 26 '23 07:09 Kagamia

@Kagamia The Halloween themed maps are now present in MSEA v226.

  • 100000000: Henesys
  • 240000000: Leafre
  • 450001000: Nameless Town

nanochromatic avatar Oct 04 '23 02:10 nanochromatic

20231003230610927_450001000 Following up on what @nanochromatic posted above. This is a screenshot from 450001000 in MSEA v226. Malgeum showcased it in this video as well: https://youtu.be/tOV2ID4ZIaQ?t=74

PirateIzzy avatar Oct 04 '23 03:10 PirateIzzy

Thanks for acknowledgement. There must be something different between KMS and MSEA client. Fortunately I have an old KMS client version so I'll try to find it out.

I believe that it's time to implement a REAL global lighting system now, but before I start, mapRender needs a refactor to make it easy to filter components with condition.

There's no ETA for the feature, but I can share a POC demo when it is ready.

Kagamia avatar Oct 04 '23 04:10 Kagamia

Maple_041023_134917 image (4) image (3) image (2) Just as another follow-up, I obtained a few screenshots of the MSEA versions in-game.

PirateIzzy avatar Oct 04 '23 05:10 PirateIzzy

image lol

the mimimap is totally wrong.

Kagamia avatar Oct 04 '23 06:10 Kagamia

Find it.

obj client-ver z canvas
450001000.img\3\obj\17 KMS 8 Map/Obj/extinction.img/extinction/foothold0/6/0
450001000.img\3\obj\17 MSEA 7 <- here is the difference (same as above)
450001000.img\3\obj\54 KMS 7 Map/Obj/halloween_2016.img/noName/obj_ani/30/0
450001000.img\3\obj\54 MSEA 7 (same as above)

The glowing object should have lower z than the lit object, but in MSEA it upside down.

WcR2 does not really support global light yet, just render the light obj with additive blend instead of alpha blend to make it looks better.

Despite all this, It seems to prove that global lighting ignores z-layer sorting, it is a good news that we still have new discoveries from the buggy client.

Kagamia avatar Oct 04 '23 11:10 Kagamia

progress: 40%

image

Kagamia avatar Oct 05 '23 10:10 Kagamia

progress: 85%

MSEA 450001000.img + KMS, even some assets are missing but looks better than before. 20231006003230929_450001000

I believe it is an acceptable version but not perfect, lots of parameters are not used, but we can make it better in future.

Kagamia avatar Oct 05 '23 16:10 Kagamia

Just wanted to provide an update from KMST 1.2.162, these are the latest map renders:

20231019211030791_100000000 20231019211009694_450001000 20231019211020574_410000500

None for Leafre

PirateIzzy avatar Oct 20 '23 01:10 PirateIzzy

Looks some light objects are not tracked. will take a look tomorrow.

Kagamia avatar Oct 20 '23 13:10 Kagamia

image

🤣

Kagamia avatar Oct 20 '23 13:10 Kagamia