Verify that mods and their dependencies are always installed as part of a transaction

[netkan-bot]

Issue by reseune Thursday Jan 01, 2015 at 09:54 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT Originally opened as https://github.com/KSP-CKAN/CKAN-support/issues/46

---

CKAN 1.5.0 The first time I used CKAN, I received an error message (my fault, forgot to delete something) near the end of the install process. CKAN said it reverted my gamedata to its previous state. However, two of my installs had dependencies that I had not selected (Community Resource Package and Firespitter Core) that CKAN automagically installed. When CKAN reverted, it did not remove the dependencies it had installed. Then, on my second attempt, CKAN detected CRP and Firespitter as AD installs, and errored out rather than override them.

[pjf]

This sounds like a serious error if it's still present. We should always be installing files as part of a transaction. Since we'd only ever be emulating a transaction when running on a non-transactional filesystem (which is practically all of them) we can end up with an inconsistent GameData if the client is forcibly killed while running, but everything should be returned to its pristine state if we just bail out normally because something's gone wrong.

I'm popping this into our to-do list to make sure that we:

• [ ] Emit warnings or krakens if we try to install or remove a mod outside of a transaction (I believe we already do this)
• [ ] Are always using transactions when installing mods via the GUI (I believe we do this as well)

[archer884]

Nope, you're right. :)

ChinhDo.