CKAN Launch game from ConsoleUI

I made console UI launch the game with f2, fixes #3534 I still need to internationalize the incompatible Mod Warning, What would be the best way to do that? Also hows it looking so far

Apr 15 '22 19:04 CSutter5

Hi and thanks for another submission! I will try to get the first round of code review done within the next week or so.

You don't have to worry about internationalization of Core or ConsoleUI code yet because #3482 is not yet merged to master; you only need to worry about being compatible with the code that's already in master. If your PR merges first, I will update that other PR to internationalize any new code.

Apr 15 '22 19:04 HebaruSan

I didn't even know that was planned, or being worked on

Apr 15 '22 20:04 CSutter5

I didn't even know that was planned, or being worked on

Yup! You can see everything we're currently working on here:

https://github.com/KSP-CKAN/CKAN/pulls

Apr 16 '22 00:04 HebaruSan

Looking back at some of the code I don't think I'm ready for a code review quite yet

Apr 16 '22 13:04 CSutter5

I think its ready @HebaruSan

Apr 22 '22 20:04 CSutter5

About 114 tests are failing with null reference errors. They should pass before code review starts.

May 03 '22 02:05 HebaruSan

Hi @PizzaRules668, you can run ./build test (Linux) or .\build.ps1 test (Windows) to run the tests locally. They need to pass before we can merge.

Aug 11 '22 15:08 HebaruSan

Hi @PizzaRules668, if you have a chance to come back to this and fix the failing tests, please let us know and we can re-open this. Closing as incomplete and inactive.

Mar 10 '24 06:03 HebaruSan