gitlab-dashboard icon indicating copy to clipboard operation
gitlab-dashboard copied to clipboard

Published 20 hours ago • verified publisher icon KSF-Media

Running times are wrong

Open f-f opened this issue 7 years ago • 1 comments

Running times for stages are usually displayed as 23:56:44, which are obviously wrong.

f-f avatar Jan 23 '18 16:01 f-f

Some context about this: we had a bug about times being weird, which was "fixed" by https://github.com/KSF-Media/gitlab-dashboard/commit/979282444fa48c39892067aa76dc1122e1b4f4a2 ("reverted" in https://github.com/KSF-Media/gitlab-dashboard/commit/3093d95c6ede51dd0d9acee353128cf6dd2f9a5e). A posteriori we realized that the running times were weird because some finished was on a different day but at a previous time than the started, so since the running time are capped to 24h in the visualization, we get weird times. So everything is fine if the difference between started and finished attributes of the Pipeline is less than 24h.

We could fix this in several ways:

  1. Display something different if the difference is more than 24h, e.g. branching here
  2. (my favorite) Instead of just diffing the started and finished (which don't actually represent the running time), we should sum all the jobs running times (with the assumption that the sum of the duration of jobs would practically never go over 24h)

f-f avatar Jul 03 '18 14:07 f-f