spotube icon indicating copy to clipboard operation
spotube copied to clipboard

Future bug: youtube ad injection into videos

Open s-b-repo opened this issue 1 year ago • 9 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current Behavior

YouTube is experimenting with server side injecting ads into videos which may break clients adblockers sponserblocker

Expected Behavior

will break extentions and clients

Steps to reproduce

might be coming in the future detected by sponsorblock

Operating System

all

Spotube version

all

Installation source

GitHub Releases (Binary)

Additional information

No response

Self grab

  • [X] I'm ready to work on this issue!

s-b-repo avatar Jun 17 '24 20:06 s-b-repo

https://www.youtube.com/watch?v=9JYFMMNYz60&pp=ygUUeW91dHViZSBhZCBpbmplY3Rpb24%3D someordinarygamer goes into more detail

s-b-repo avatar Jun 17 '24 20:06 s-b-repo

I mean, it sure is a problem for Spotube. I didn't thin of that one. D'amm, Google is realy bad... Well I guess a lot of project should come together and found a solution xD. Anyway, I was going to say you can donwload and play the songs localy but... yeah, it might donwload ads that got into the music.

Peperehobbits01 avatar Jun 28 '24 10:06 Peperehobbits01

True this is a big discussion. "How to fix that?" is now really a million dollar question. I guess for now we've to find more sources like we found JioSaavn.

KRTirtho avatar Jul 09 '24 13:07 KRTirtho

Can SoundCloud be used as a source? Also ai can detect ads on loading the song and flag the periods to be skipped or detect the increase in length and/or without ai it detects if the song gets cut off

tectrixdev avatar Jul 15 '24 12:07 tectrixdev

Maybe but the ai as to be trained... and well that requires a lot of resources.

Peperehobbits01 avatar Jul 15 '24 13:07 Peperehobbits01

It would be better to wait until youtube actually releases this feature as a whole and even then, sponsorblock probably will come up with an implementation which we can utilise without needing to implement it in spotube.

ksharizard avatar Jul 15 '24 18:07 ksharizard

Yeah, I agree.

Peperehobbits01 avatar Jul 15 '24 19:07 Peperehobbits01

Why not just implement code from uBlock Origin?

BlastBlaster17 avatar Jul 26 '24 20:07 BlastBlaster17

Why not just implement code from uBlock Origin?

Maybe because it's not a electron app. So you would need to make it compatible, wich my not be impossible. It's not easy and takes a lot of effort and time. And not realy viable for the future, as more updates of the app would be required, and a lot of other stuff. It's already enough hard for @KRTirtho to be the maintainer and I don't think it's worth do to all of that and make it much worse for him. We have to remember that people developing this software are doing it for free. Whit the time they have.

Peperehobbits01 avatar Jul 30 '24 09:07 Peperehobbits01