spotube icon indicating copy to clipboard operation
spotube copied to clipboard
verified publisher icon KRTirtho

Added checks to the youtube rank results method

Open royash123 opened this issue 2 years ago • 2 comments

see https://github.com/KRTirtho/spotube/discussions/1186

royash123 avatar Feb 01 '24 11:02 royash123

It appears this PR also includes the commit from my other PR.

royash123 avatar Feb 03 '24 20:02 royash123

Thanks for the contribution Can you please remove the unrelated commits or revert back the unrelated changes?

KRTirtho avatar Feb 04 '24 04:02 KRTirtho

Bringing this up, should this PR be accepted?

royash123 avatar Apr 06 '24 08:04 royash123

Not sure as I recently added song.link support, which pretty much always results with accurate matches. Also, I tested out your PR, it works good for popular music. But for country music, or regional tracks it kind of falls of just like the old implementation

KRTirtho avatar Apr 11 '24 15:04 KRTirtho