Config housekeeping

[DarthParametric]

1.9.0 beta test observations:

• [x] There are some LIP files being dumped into the Override folder. Fixes from an earlier release? They could stand to be injected into the appropriate MOD in line with all other LIP files.

File275=nm03aakand01009_.lip -> lips\tar_m03aa_loc.mod (seems to already be there? Carth's interjection about exploding swoop?) File276=nm18abbast14000_.lip -> lips\tat_m18ab_loc.mod (Bastila's holocron in the Krayt cave) File277=nm18abbast14002_.lip -> lips\tat_m18ab_loc.mod (Bastila's holocron in the Krayt cave) File278=nm41aacart04148_.lip -> lips\unk_m41aa_loc.mod (Party showdown on Lehon Central Beach?) File279=nm41aacart04149_.lip -> lips\unk_m41aa_loc.mod (Party showdown on Lehon Central Beach?)

[DarthParametric]

• [x] @N-DReW25 has queried the inclusion of l_commm/l_commf models and whether they are still necessary. Edit: Seems they aren't. They can be removed and the appearance.2da race entries for the revised lite commoner rows swapped to N_CommM/F.

This was actually erroneous. These models are used for the placeable sitters.

[DarthParametric]

• [x] Player appearance.2da rows are duplicated (how did we miss that for so long?). But I think they need to be removed entirely and the walk/run values reverted to vanilla. With the change introduced in #445, the player now walks far too slowly.

[JCarter426]

• There are some LIP files being dumped into the Override folder. Fixes from an earlier release? They could stand to be injected into the appropriate MOD in line with all other LIP files.

As I recall, LIP files are currently installed to Override because the MOD files in lips\ are the original game files, so patching them would mean modifying the original game files without an easy way for the end user to undo it.

Maybe this isn't that big of a deal to everyone, and there might be a better way of going about it, but I think that was the reason before.

[DarthParametric]

• [x] Per #585, we should add the ExclusiveColumn field to all added 2DA rows in changes.ini to prevent the duplication of rows if the installer is run multiple times. Eleven added rows in appearance.2da and one added row in soundset.2da as of v1.9.2.

[DarthParametric]

• [x] MP3s used instead of WAVs with a fake header for the Sandral droid edited VO:

install_folder75=streamwaves\m14ad\sdro04

[install_folder75]
File0=NM14ADSDRO04091_.mp3
File1=NM14ADSDRO04092_.mp3

[DarthParametric]

Whoops, premature closure. I forgot this one:

• [x] Abandon config-based patching of Vandar's Enclave DLG (dan13_vandar.dlg) and move to a straight overwrite given the extent of the changes (8.6K config lines currently).

[DarthParametric]

• [x] Override folder file list needs to be switched to all Replace.

[DarthParametric]

• [ ] ~TSLPatcher appears to fail to implement \CameraID=-1 when editing existing DLG camera IDs. Switch to 4294967295 the same as used for setting the Delay field to -1.~ Edit: Reverted, since TSLPatcher throws a fatal exception when attempting this.

[DarthParametric]

Some additional housekeeping: LIPs are injected into the Korriban Sith Academy module (korr_m35aa.mod - config block install_folder21) instead of the appropriate MOD in the lips folder.

[JCarter426]

Installation to modules should be preferred because not all platforms handle localization in the same way.

[DarthParametric]

I assume this is a reference to the Switch? Should we change the existing lip folder injections then? Or release a separate Switch version, since presumably it also needs additional changes to the Override folder?

[JCarter426]

It's an issue with mobile as well as Switch. Keeping it as is installing to the module will work with any release so I don't think it's worth changing or making an alternate installer. It also has the benefit of altering fewer original game files.

[DarthParametric]

At present I think it's only a single fix/module where that happens. All the others get injected into their relevant MOD in the Lips folder. So presumably you want to change all those to module injection as well then?

[JCarter426]

I still see several of them being installed to modules/korr_m35aa.mod. I thought they all were originally installed to modules or override so I'm not sure when the others were moved.

[DarthParametric]

All the ones I have committed have been straight to the Lips folder. And I also migrated some pre-1.7 Override dumps there as well, per the 1st comment.

[JCarter426]

Well, I think they should be installed to their relevant modules/*.mod file rather than lips/*.mod file, as the Korriban lips were originally.

[DarthParametric]

They can be re-routed to module MODs easily enough, but the install folder list would then ideally need a cleanup with that sorting tool of yours to remove the unused LIP folders.

[DarthParametric]

as the Korriban lips were originally

It appears those - or some at least - are still being injected into the module. There are currently eight install targets for .lip files:

install_folder21=modules\korr_m35aa.mod
install_folder81=lips\tar_m05aa_loc.mod
install_folder83=lips\ebo_m12aa_loc.mod
install_folder92=lips\localization.mod
install_folder93=lips\korr_m38ab_loc.mod
install_folder97=lips\unk_m41aa_loc.mod
install_folder104=lips\tar_m11aa_loc.mod
install_folder105=lips\tat_m18ab_loc.mod

Folder 21 (Sith Academy) is all generic Twi'lek stuff.

Folder 92 appears to be a Jolee line - nm35aajole09599_.lip - not sure how that ended up in localization.mod. Edit: Overwriting an existing one perhaps. We edit one of his global DLG lines to remove a reference to the Wookiees being gardeners since it can trigger before activating the Kashyyyk starmap.

[JCarter426]

Folder 92 appears to be a Jolee line - nm35aajole09599_.lip - not sure how that ended up in localization.mod.

A lot of global lines are in the Korriban folders for some reason. It looks like this is a new line added by the Community Patch related to #446

[DarthParametric]

What would you suggest for global lips then? Seems like they would have to go in the Override? Seems to be just that single Jolee one at the moment.

[JCarter426]

It would have to be Override for that one, I guess, yeah. Of course, you could put it in the rims folder but that would be worse.

[DarthParametric]

• [x] There are some commented out config blocks relating to the deprecated tier list that can be removed
• [x] The comment block at the top of the ini still flags it as the prior release version, 1.9.2
• [x] Technically not config related, but the edited credits roll TLK strings need updating for 1.10.0

[DarthParametric]

Some ini errors:

• [ ] ~The lips and wavs for Bastila's added DLG for finding her father's holocron are going in the wrong folders. There are being pointed at folders for tat_m18ab (Sandpeople Territory) instead of tat_m18ac (Eastern Dune Sea).~ Edit: Seems that's where the vanilla audio is. Maybe there was originally meant to be a second (third?) Krayt.
• [x] ~There are apparently conflicting installations of UTCs for Xor's mooks, module injections and an Override dump (reported by @th3w1zard1 on the DS Discord).~ Edit: Disregard. kas_xor1.utc is Xor himself. This is the change that swaps him from a Twi'lek back to a human. Although I'm curious as to why that wasn't an appearance.2da edit, since he has a unique row. The initial messenger Xor (g_xor.utc) is also handled the same way. Seems like the better approach is to just edit the appearance row and remove the two UTCs from the Override.
• [x] There appears to be at least one duplicate in the GFF list due to naming scheme. The list needs to be sorted and some of the naming clarified/corrected.

Reversion:

• [x] The fat commoner model addition should be stripped out and left to a third party mod. I'll post the models as a modder's resource on DS.

Other:

• [x] Per the above convo, change lips to be injected into the appropriate module MOD instead of in lips folder.
• [ ] With the removal of injection into the Lips folder, the install folder list now skips some numbers. Could do with being freshly sorted and renumbered, as @JCarter426 did with a custom tool in a previous release.

[Leilukin]

~There are apparently conflicting installations of UTCs for Xor's mooks, module injections and an Override dump (reported by @th3w1zard1 on the DS Discord).~ Edit: Disregard. kas_xor1.utc is Xor himself. This is the change that swaps him from a Twi'lek back to a human. Although I'm curious as to why that wasn't an appearance.2da edit, since he has a unique row. The initial messenger Xor (g_xor.utc) is also handled the same way. Seems like the better approach is to just edit the appearance row and remove the two UTCs from the Override.

K1CP's change that swaps Xor from a Twi'lek back to a human like in the Xbox version originally came from my Human Xor Restoration mod. Since the human Xor appearance uses a generic commoner one, I thought it would be easier to edit the UTCs to point to the generic white commoner row than edit appearance.2da.

That said, if editing the appearance row is the better approach, feel free to do so.

[DarthParametric]

• [x] The config blocks for some Duros UTCs are missing, although thanks to their naming they still appear to install.

[dan14ab_duros01.utc]
!Destination=modules\danm14ab.mod
AddField0=featlist_proficiency_all
[featlist_proficiency_all]
FieldType=Struct
Path=FeatList
Label=
TypeId=1
AddField0=feat_proficiency_all
[feat_proficiency_all]
FieldType=Word
Label=Feat
Value=93
[dan14ab_duros02.utc]
!Destination=modules\danm14ab.mod
AddField0=featlist_proficiency_all
[dan14ab_duros03.utc]
!Destination=modules\danm14ab.mod
AddField0=featlist_proficiency_all
[dan14ac_duros01.utc]
!Destination=modules\danm14ac.mod
AddField0=featlist_proficiency_all
AddField1=gff_dan14ac_duros01_ItemList_0
[gff_dan14ac_duros01_ItemList_0]
FieldType=List
Path=
Label=ItemList
AddField0=gff_dan14ac_duros01_ItemList_0_0
[gff_dan14ac_duros01_ItemList_0_0]
FieldType=Struct
Label=
TypeId=0
AddField0=gff_dan14ac_duros01_InventoryRes_0
AddField1=gff_dan14ac_duros01_Repos_PosX_0
AddField2=gff_dan14ac_duros01_Repos_PosY_0
[gff_dan14ac_duros01_InventoryRes_0]
FieldType=ResRef
Label=InventoryRes
Value=g_w_vbroshort01
[gff_dan14ac_duros01_Repos_PosX_0]
FieldType=Word
Label=Repos_PosX
Value=0
[gff_dan14ac_duros01_Repos_PosY_0]
FieldType=Word
Label=Repos_PosY
Value=0
[dan14ac_duros02.utc]
!Destination=modules\danm14ac.mod
AddField0=featlist_proficiency_all

Lines 8255 to 8302.

[DarthParametric]

A sorting of the install folder numbers would be nice for my OCD, but is not a necessity. Going to call this done. We can always pretty it up at some later date if someone supplies the tool to do so.

[DarthParametric]

The LIP files for Bastila's father's holocron DLG (nm18abbast14000_.lip / nm18abbast14002_.lip) are being injected into the wrong module. They are currently going into tat_m18ab.mod instead of into tat_m18ac.mod.

[DarthParametric]

Added K1CP addendum to credits TLK entry needs an update.

[DarthParametric]

• [x] The TSL blue Twi'lek male head model and texture are still being installed to the Override, despite being removed from the 2DAs.
• [x] Most of the added Aspyr font images can probably be removed. Seems like only fnt_creditsb and maybe fnt_d16x16 are needed.

[DarthParametric]

Based on a comparison of the contents of tslpatchdata vs the ini, the following changes need to be made:

• [ ] cp_dan_c_ahlan.ncs needs to be injected into the Sandral Grounds module (danm16.mod).
• [ ] k_pdan_elise_d.ncs needs to be injected into the Enclave Courtyard module (danm14aa.mod).
• [ ] heads.2da needs to be deleted from tslpatchdata.
• [ ] N_CommF33.tpc needs to be deleted from tslpatchdata.
• [x] The previous reversion of the fat commoner was incomplete. The 2DA rows need the models switched to the regular commoner model (see #786).