kmk_firmware icon indicating copy to clipboard operation
kmk_firmware copied to clipboard

Peg module performance improvements

Open janlindblom opened this issue 3 years ago • 5 comments

  • Improve Peg OLED extension performance (remove flicker/flash when changing content based on current layer).
  • Update Peg RGB extension to support RGB LED brightness change and add two keycodes to increase/decrease brightness.

janlindblom avatar Aug 05 '22 14:08 janlindblom

@daysgobye First new PR to replace my previous PR which includes only updates to existing Peg OLED and RGB LED extensions.

janlindblom avatar Aug 05 '22 14:08 janlindblom

Thanks @kdb424 !

janlindblom avatar Aug 05 '22 18:08 janlindblom

By the way @daysgobye , is the Peg desktop client open source? I'm having quite a few performance issues with it and was wondering if there was a way to debug it. Mainly, it's just gripes about the app doing or not doing stuff and no feedback in the UI as to what it's up to behind the chrome and some situations where it freezes up without a clear indication as to what happened.

janlindblom avatar Aug 05 '22 19:08 janlindblom

By the way @daysgobye , is the Peg desktop client open source? I'm having quite a few performance issues with it and was wondering if there was a way to debug it. Mainly, it's just gripes about the app doing or not doing stuff and no feedback in the UI as to what it's up to behind the chrome and some situations where it freezes up without a clear indication as to what happened.

It's closed source, but maintains a github for keyboard support and issue tracking.

kdb424 avatar Aug 09 '22 20:08 kdb424

Linting is broken. Please run make test before committing to prevent these issues. make fix-formatting fix-isort should solve most of the issues in general for this reason.

kdb424 avatar Aug 09 '22 20:08 kdb424

Once the linter is happy, I'd love to see this merged.

kdb424 avatar Sep 01 '22 01:09 kdb424

Can we get a linting fix on this so I can merge? If not, I'll take over.

kdb424 avatar Sep 08 '22 02:09 kdb424

Sorry for arriving late but I see you took care of it, thanks!

janlindblom avatar Sep 21 '22 14:09 janlindblom