Nabil Tharwat

Results 34 comments of Nabil Tharwat

Perhaps the `maxConcurrency` option can be specified as part of the options? I have a bot that produces images and spawning an instance every time to render images is a...

Just discovered another performance-related issue. You create a cluster for a batch of jobs, but the maxConcurrency option fails to use the full advantage of `puppeteer-cluser` AND the fact that...

Spawning a cluster on a clean start of the bot took `3,000ms`. ![image](https://user-images.githubusercontent.com/20807178/103302602-b617ad00-4a0c-11eb-9452-d06b9246ed96.png) Subsequent spawns took an average of over `300ms`. ![image](https://user-images.githubusercontent.com/20807178/103302584-ad26db80-4a0c-11eb-8a05-a3a8d6ce9ab0.png)

@frinyvonnick The changes would be significant in terms of performance and not go beyond a few lines of code.

This seems to be affecting more than just me.

I guess the explanation is meant for people who are not experts and don't actually look into the spec itself. "Global execution context" to a newbie's ears is way easier...

> * We still want to keep dark background. Not only is this pretty much the point since canvas takes up 90% of your screen (or more), but the dark...

It does the rotation using CSS, which is a GPU-accelerated native operation. Doing it with JS would be a ton slower, AFAICT. Also, using different colors wouldn't solve it, as...

Hey! I can work on this since I want it too. Just point me in the right direction, what needs to change, etc.

Hey @kylegach , this doesn't solve the problem of having Jest report all my snapshots as obsolete. Is there a way around this?