PortableBitfields icon indicating copy to clipboard operation
PortableBitfields copied to clipboard

Hotfix/fix signed to unsigned warning

Open KevinNelsonPlexus opened this issue 9 months ago • 3 comments

adding static cast to suppress compiler warnings

KevinNelsonPlexus avatar Mar 29 '25 05:03 KevinNelsonPlexus

Thank you for contributing!

I can see that there is much more added here than fixing compiler warnings. ;)

However, I am willing to merge the other things, but all in separate PRs:

  • CMakePresets
  • clang-format and clang-tidy together.
  • I would like not to merge the .vscode/ directory.
  • The contributing note is not necessary. The intuitive, GitHub-driven collaboration approach is good to me.
  • Nice finding with the CPM! I could merge it too, but also in a separate PR.

KKoovalsky avatar Jul 01 '25 11:07 KKoovalsky

Whoops - a bunch of those commits are tweaks I did to make the code more friendly to use with Plexus internal standards. I'll see if I can generate a PR with the minimum amount of changes needed.

KevinNelsonPlexus avatar Jul 02 '25 17:07 KevinNelsonPlexus

Thank you for contributing!

I can see that there is much more added here than fixing compiler warnings. ;)

However, I am willing to merge the other things, but all in separate PRs:

  • CMakePresets
  • clang-format and clang-tidy together.
  • I would like not to merge the .vscode/ directory.
  • The contributing note is not necessary. The intuitive, GitHub-driven collaboration approach is good to me.
  • Nice finding with the CPM! I could merge it too, but also in a separate PR.

I believe all of the "other things" have been broken into their own PRs:

Please let me know if I missed anything. Thanks!

kwalker-plxs avatar Jul 24 '25 20:07 kwalker-plxs