kilt-node icon indicating copy to clipboard operation
kilt-node copied to clipboard

Published 20 hours ago • verified publisher icon KILTprotocol

ci: caching

Open ggera opened this issue 1 year ago • 2 comments

fixes KILTProtocol/ticket#3345

Breaks up the on gitlab-ci.yml & adds one more stage release.

  • [x] Gitlab needs to speed up pipeline
  • [x] Reuses artifacts from previous jobs
  • [x] Parallel command execution

Metadata Diff to Develop Branch

Peregrine Diff
Spiritnet Diff

Checklist:

  • [ ] I have verified that the code works
    • [ ] No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • [ ] I have verified that the code is easy to understand
    • [ ] If not, I have left a well-balanced amount of inline comments
  • [ ] I have left the code in a better state
  • [ ] I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

ggera avatar Jun 14 '24 14:06 ggera

I'd like to get a bit more context into the different pieces of this PR, especially regarding the new try-runtime file.

I'd like to get a bit more context into the different pieces of this PR, especially regarding the new try-runtime file.

Tested self hosted github action yet It takes way longer than gitlab. Check here

ggera avatar Jun 24 '24 15:06 ggera

Hey @ggera I'll unsubscribe from this issue to reduce notifications. Please re-request a review when all the changes are in!

ntn-x2 avatar Jun 27 '24 14:06 ntn-x2

A few more questions that would help me understand the setup and the assumptions you took even better.

Also, in general, how will the Gitlab and GitHub jobs interact with each other? I did not see any logic that would trigger one based on the result of the other?

There is no direct dependency between GitLab and GitHub jobs. We have a pull mirror setup, which usually experiences a delay of at least 5 minutes due to its regular interval pull synchronization.If needed we can introduce instant webhook synch in another ticket

ggera avatar Jul 24 '24 10:07 ggera

There is no direct dependency between GitLab and GitHub jobs. We have a pull mirror setup, which usually experiences a delay of at least 5 minutes due to its regular interval pull synchronization.If needed we can introduce instant webhook synch in another ticket

So how does one platform know when to run the tests? What if they fail on one platform? Is the other notified? E.g. we don't want to build a Docker image if we know the tests do not go through, or don't want to run try-runtime tests if we fail to run the unit tests.

ntn-x2 avatar Jul 29 '24 12:07 ntn-x2