kilt-node icon indicating copy to clipboard operation
kilt-node copied to clipboard

chore: remove unused deps

Open ntn-x2 opened this issue 1 year ago • 3 comments

WIP.

Checklist

Make sure the following combinations work as expected, as they are the most useful ones:

  • [ ] --all-targets: no default features, this is the final WASM that is deployed
  • [ ] --all-targets --all-features: all features enabled, which can reduce our compile times by eliminating unnecessary dependencies

ntn-x2 avatar Feb 09 '24 14:02 ntn-x2

Problem I'm having is with a dev dependency that is only used when the benchmarks are being tested. This is currently not possible to remove, hence I was thinking to either add a new feature and make the dependency a regular optional dependency instead of a dev one, or then just try what other tools like cargo-udeps and cargo-machete yield. This is low priority but still somehow important to reduce the size of our WASM, binaries and bring down compilation times.

ntn-x2 avatar Feb 12 '24 06:02 ntn-x2

@Antonio what is the status of this?

Dudleyneedham avatar May 24 '24 12:05 Dudleyneedham

Will pick it up again at some point, probably next week.

ntn-x2 avatar May 24 '24 13:05 ntn-x2

Closing for now. Will make a proper ticket to track this.

ntn-x2 avatar May 31 '24 07:05 ntn-x2