kaos icon indicating copy to clipboard operation
kaos copied to clipboard

Remove hardcoded color from cli/kaos_cli/commands/build.py

Open atselikov opened this issue 4 years ago • 2 comments

What is the desired change?

Based on code review last week it would be nice to make terminal color handling in cli/kaos_cli/commands/build.py in the same way, as we have it in other modules (train, serve, etc...):

@build.command(name='deploy',
               short_help='{}'.format(
                   click.style('Build the kaos backend', bold=True, fg='black')))

->

@serve.command(name='deploy',
               short_help='Configure and serve an ML model')

How will this change improve kaos?

No point to have command's color hardcoded (maybe apart of kill command warning). As we saw on the code review demo - it could be invisible because of a terminal different color scheme.

Any thoughts on the implementation approach?

Refactoring

atselikov avatar Dec 16 '19 16:12 atselikov

  1. The color scheme bug is fixed under the PR #95.
  2. Also added more description based on newly added feature

ms-shankar avatar Jan 24 '20 08:01 ms-shankar

Screen Shot 2020-01-24 at 09 47 32 Screen Shot 2020-01-24 at 09 47 46

ms-shankar avatar Jan 24 '20 08:01 ms-shankar