Hodor
Hodor copied to clipboard
Code readability Improvement
I asked Rishat who is joining as our frontend lead engineer next month. He shared the updated code with me and I just replaced it in the app.js
.
I think if we are publishing it to the world then it makes sense to ask for feedback and show the best version of our code :)
His comment and I am quoting:
Why
return 'success'
tho? It doesn’t really mean success, and it returns before the asynchronous call finishes execution. May be a source of trouble even.
Please test it first in production and see if there are no newly introduced bugs. If looks better than your code then I would say include this in the medium post and also a good learning for you then.