hotspot
hotspot copied to clipboard
KDAB
Better disassembly
This is marvelous! I'd really like to see that integrated. [side note: is there still a CI building AppImage anywhere? old travis is gone and the last CI release is nearly 7 months old]
closes #9
Note: for GitHub to recognize this please edit the first post and add the information there
@lievenhey moin, this is looking good and we could merge it as-is as it's an improvement.
But we definitely need to handle inlining better, see https://github.com/KDAB/hotspot/pull/390/commits/72fec27e4ba517ac9a7f9245dc6cdc2ebca7faa2 for some easy work from towards that direction. Could you look into improving this further based on the cpp-inlining example? Things that I'd like to see:
- source listings for all files encountered in a function in a combined SourceCodeModel tree model, the file name on the first level and then second level shows source code lines like it does currently
- combined source line costs when code gets inlined from somewhere, this screenshot should hopefully make this clear:
note how the code is basically all within inlined code, so currently we show 0% cost everywhere which is super misleading
This is really cool! The CI builds don't provide an AppImage, do they? 'd love to test the new annotation and disassembly.
Not yet, no - I'll build one manually next week (and do a proper new release too :crossed_fingers:)
But note that there's still some work left to do in the disassembly wrt inline frames
Just rechecking @milianw, does this mean we can expect Hotspot 1.4.0 "soonish"?