hotspot
hotspot copied to clipboard
KDAB
SSH
These patches allow hotspot to run perf record on remote devices via ssh. The recording data is streamed directly to hotspot without storing it on the device.
fixes #12
Thank you for this nice addition, it seems that README.md may need an update (or is this actually a draft implementation so "too early for that")?
weird, somehow the ui on the mainwindow got changed, but I didn't touch that file.
@milianw I'm wondering where this has gone, the requested changes seem to have been done.
related to #12
Actually this "fixes #12" - maybe someone can edit the first post or better directly link it.
Solving the conflicts would be nice; the reason I'm asking for it is that this would trigger CI, which now creates an AppImage which then can be used to test the feature before it is integrated.
I've tested that with the generated appimage and when doing "test connection and save" I always just get an empty error message:
with stderr having
QProcess: Destroyed while process ("/usr/bin/ssh") is still running.
How to debug this issue? (note: /usr/bin/ssh -K ruser@rmach works like a charm)
Side note: the configuration dialog is named "Paths and Architecture Settings" which is getting even more wrong after applying this, I've created #436 to tackle that.
@GitMensch ~~It should now work~~ connecting does work, recording not (I messed up the order of arguments and ended up calling ssh host@user)
Rechecked with hotspot-v1.3.0-374-g97c6a8e-x86_64.AppImage - still the same result (empty error + that message in stderr). Can I suggest to add "command failed: $sshCommandHere" as start of the error message?
The SSH config now does work (note: if available it would be useful to read in ~/.ssh/config for the list of hosts).
To get it saved on has to manually click on "copy config".
... but I was not able to record, the "start profiling" was always grey.